enclose-io/compiler

View on GitHub
current/benchmark/crypto/cipher-stream.js

Summary

Maintainability
F
4 days
Test Coverage

Function streamWrite has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

function streamWrite(alice, bob, message, encoding, writes) {
Severity: Minor
Found in current/benchmark/crypto/cipher-stream.js - About 35 mins to fix

    Function legacyWrite has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    function legacyWrite(alice, bob, message, encoding, writes) {
    Severity: Minor
    Found in current/benchmark/crypto/cipher-stream.js - About 35 mins to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

      function main({ api, cipher, type, len, writes }) {
        if (api === 'stream' && /^v0\.[0-8]\./.test(process.version)) {
          console.error('Crypto streams not available until v0.10');
          // Use the legacy, just so that we can compare them.
          api = 'legacy';
      Severity: Major
      Found in current/benchmark/crypto/cipher-stream.js and 1 other location - About 2 days to fix
      lts/benchmark/crypto/cipher-stream.js on lines 14..63

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 413.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

      function legacyWrite(alice, bob, message, encoding, writes) {
        let written = 0;
        let enc, dec;
        for (let i = 0; i < writes; i++) {
          enc = alice.update(message, encoding);
      Severity: Major
      Found in current/benchmark/crypto/cipher-stream.js and 1 other location - About 7 hrs to fix
      lts/benchmark/crypto/cipher-stream.js on lines 86..101

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 188.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

      function streamWrite(alice, bob, message, encoding, writes) {
        let written = 0;
        bob.on('data', (c) => {
          written += c.length;
        });
      Severity: Major
      Found in current/benchmark/crypto/cipher-stream.js and 1 other location - About 5 hrs to fix
      lts/benchmark/crypto/cipher-stream.js on lines 65..84

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 152.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

      const bench = common.createBenchmark(main, {
        writes: [500],
        cipher: ['AES192', 'AES256'],
        type: ['asc', 'utf', 'buf'],
        len: [2, 1024, 102400, 1024 * 1024],
      Severity: Major
      Found in current/benchmark/crypto/cipher-stream.js and 1 other location - About 1 hr to fix
      lts/benchmark/crypto/cipher-stream.js on lines 4..12

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 72.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status