Sign upLogin

enclose-io/compiler

View on GitHub
Star
current/benchmark/url/legacy-vs-whatwg-url-searchparams-parse.js

Summary

Maintainability
C
1 day
Test Coverage

Identical blocks of code found in 4 locations. Consider refactoring.
Open

function main({ searchParam, n, method }) {
  const param = searchParams[searchParam];
  if (!param) {
    throw new Error(`Unknown search parameter type "${searchParam}"`);
  }
Severity: Major
Found in current/benchmark/url/legacy-vs-whatwg-url-searchparams-parse.js and 3 other locations - About 3 hrs to fix
current/benchmark/url/legacy-vs-whatwg-url-searchparams-serialize.js on lines 33..49
lts/benchmark/url/legacy-vs-whatwg-url-searchparams-parse.js on lines 31..47
lts/benchmark/url/legacy-vs-whatwg-url-searchparams-serialize.js on lines 33..49

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 109.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

function useLegacy(n, input) {
  querystring.parse(input);
  bench.start();
  for (let i = 0; i < n; i += 1) {
    querystring.parse(input);
Severity: Major
Found in current/benchmark/url/legacy-vs-whatwg-url-searchparams-parse.js and 1 other location - About 2 hrs to fix
lts/benchmark/url/legacy-vs-whatwg-url-searchparams-parse.js on lines 13..20

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 78.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

function useWHATWG(n, param) {
  new URLSearchParams(param);
  bench.start();
  for (let i = 0; i < n; i += 1) {
    new URLSearchParams(param);
Severity: Major
Found in current/benchmark/url/legacy-vs-whatwg-url-searchparams-parse.js and 1 other location - About 1 hr to fix
lts/benchmark/url/legacy-vs-whatwg-url-searchparams-parse.js on lines 22..29

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 70.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

const bench = common.createBenchmark(main, {
  searchParam: Object.keys(searchParams),
  method: ['legacy', 'whatwg'],
  n: [1e6]
});
Severity: Major
Found in current/benchmark/url/legacy-vs-whatwg-url-searchparams-parse.js and 5 other locations - About 30 mins to fix
current/benchmark/url/legacy-vs-whatwg-url-searchparams-serialize.js on lines 7..11
current/benchmark/url/whatwg-url-idna.js on lines 28..32
lts/benchmark/url/legacy-vs-whatwg-url-searchparams-parse.js on lines 7..11
lts/benchmark/url/legacy-vs-whatwg-url-searchparams-serialize.js on lines 7..11
lts/benchmark/url/whatwg-url-idna.js on lines 28..32

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status