enclose-io/compiler

File trace-file-reader.js has 268 lines of code (exceeds 250 allowed). Consider refactoring.

Open

// Copyright 2018 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

'use strict';

Function createModelFromV8TraceFile has 60 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  createModelFromV8TraceFile(contents) {
    console.log('Processing log as V8 trace file.');
    contents = contents.map(function(line) {
      try {
        // Strip away a potentially present adb logcat prefix.

Function createModelFromChromeTraceFile has 52 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  createModelFromChromeTraceFile(contents) {
    const data = Object.create(null);  // Final data container.
    const parseOneGCEvent = (actual_data) => {
      Object.keys(actual_data).forEach(data_set => {
        const string_entry = actual_data[data_set];

Function readFile has 33 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  readFile(file) {
    if (!file) {
      this.updateLabel('Failed to load file.');
      return;
    }

Function parseOneGCEvent has 31 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    const parseOneGCEvent = (actual_data) => {
      Object.keys(actual_data).forEach(data_set => {
        const string_entry = actual_data[data_set];
        try {
          const entry = JSON.parse(string_entry);

Avoid deeply nested control flow statements.

Open

        if (entry.id in data[entry.isolate].gcs) {
          this.createOrUpdateEntryIfNeeded(data, entry);
          this.createDatasetIfNeeded(data, entry, entry.key);
          data[entry.isolate].gcs[entry.id][entry.key].bucket_sizes =
              entry.sizes;

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  createModelFromV8TraceFile(contents) {
    console.log('Processing log as V8 trace file.');
    contents = contents.map(function(line) {
      try {
        // Strip away a potentially present adb logcat prefix.

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

  readFile(file) {
    if (!file) {
      this.updateLabel('Failed to load file.');
      return;
    }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      Object.keys(actual_data).forEach(data_set => {
        const string_entry = actual_data[data_set];
        try {
          const entry = JSON.parse(string_entry);
          this.createOrUpdateEntryIfNeeded(data, entry);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  createOrUpdateEntryIfNeeded(data, entry) {
    console.assert(entry.isolate, 'entry should have an isolate');
    if (!(entry.isolate in data)) {
      data[entry.isolate] = new Isolate(entry.isolate);
    }

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

  addInstanceTypeData(data, isolate, gc_id, data_set, instance_type, entry) {
    data[isolate].gcs[gc_id][data_set].instance_type_data[instance_type] = {
      overall: entry.overall,
      count: entry.count,
      histogram: entry.histogram,

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  createDatasetIfNeeded(data, entry, data_set) {
    if (!(data_set in data[entry.isolate].gcs[entry.id])) {
      data[entry.isolate].gcs[entry.id][data_set] = {
        instance_type_data: {},
        non_empty_instance_types: new Set(),

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

  addFieldTypeData(data, isolate, gc_id, data_set, tagged_fields,
                   inobject_smi_fields, embedder_fields, unboxed_double_fields,
                   boxed_double_fields, string_data, other_raw_fields) {
    data[isolate].gcs[gc_id][data_set].field_data = {
      tagged_fields,

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

  extendAndSanitizeModel(data) {
    const checkNonNegativeProperty = (obj, property) => {
      console.assert(obj[property] >= 0, 'negative property', obj, property);
    };

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

  handleChange(event) {
    // Used for drop and file change.
    event.preventDefault();
    var host = event.dataTransfer ? event.dataTransfer : event.target;
    this.readFile(host.files[0]);

• Read up
  Read up