Sign upLogin

enclose-io/compiler

View on GitHub
Star
lts/deps/node-inspect/lib/internal/inspect_client.js

Summary

Maintainability
F
2 wks
Test Coverage

File inspect_client.js has 282 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*
 * Copyright Node.js contributors. All rights reserved.
 *
 * Permission is hereby granted, free of charge, to any person obtaining a copy
 * of this software and associated documentation files (the "Software"), to
Severity: Minor
Found in lts/deps/node-inspect/lib/internal/inspect_client.js - About 2 hrs to fix

    Function _handleChunk has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
    Open

      _handleChunk(chunk) {
    this._unprocessed = Buffer.concat([this._unprocessed, chunk]);

    while (this._unprocessed.length > 2) {
      const {
    Severity: Minor
    Found in lts/deps/node-inspect/lib/internal/inspect_client.js - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function decodeFrameHybi17 has 55 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function decodeFrameHybi17(data) {
  const dataAvailable = data.length;
  const notComplete = { closed: false, payload: null, rest: data };
  let payloadOffset = 2;
  if ((dataAvailable - payloadOffset) < 0) return notComplete;
    Severity: Major
    Found in lts/deps/node-inspect/lib/internal/inspect_client.js - About 2 hrs to fix

      Function _connectWebsocket has 40 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        _connectWebsocket(urlPath) {
    this.reset();

    const key1 = crypto.randomBytes(16).toString('base64');
    debuglog('request websocket', key1);
      Severity: Minor
      Found in lts/deps/node-inspect/lib/internal/inspect_client.js - About 1 hr to fix

        Function _handleChunk has 40 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          _handleChunk(chunk) {
    this._unprocessed = Buffer.concat([this._unprocessed, chunk]);

    while (this._unprocessed.length > 2) {
      const {
        Severity: Minor
        Found in lts/deps/node-inspect/lib/internal/inspect_client.js - About 1 hr to fix

          Function encodeFrameHybi17 has 31 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function encodeFrameHybi17(payload) {
  var i;

  const dataLength = payload.length;
          Severity: Minor
          Found in lts/deps/node-inspect/lib/internal/inspect_client.js - About 1 hr to fix

            Function _fetchJSON has 28 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              _fetchJSON(urlPath) {
    return new Promise((resolve, reject) => {
      const httpReq = http.get({
        host: this._host,
        port: this._port,
            Severity: Minor
            Found in lts/deps/node-inspect/lib/internal/inspect_client.js - About 1 hr to fix

              Function decodeFrameHybi17 has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
              Open

              function decodeFrameHybi17(data) {
  const dataAvailable = data.length;
  const notComplete = { closed: false, payload: null, rest: data };
  let payloadOffset = 2;
  if ((dataAvailable - payloadOffset) < 0) return notComplete;
              Severity: Minor
              Found in lts/deps/node-inspect/lib/internal/inspect_client.js - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function encodeFrameHybi17 has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

              function encodeFrameHybi17(payload) {
  var i;

  const dataLength = payload.length;
              Severity: Minor
              Found in lts/deps/node-inspect/lib/internal/inspect_client.js - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

              class Client extends EventEmitter {
  constructor() {
    super();
    this.handleChunk = this._handleChunk.bind(this);
              Severity: Major
              Found in lts/deps/node-inspect/lib/internal/inspect_client.js and 1 other location - About 1 wk to fix
              current/deps/node-inspect/lib/internal/inspect_client.js on lines 166..350

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 1533.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

              function decodeFrameHybi17(data) {
  const dataAvailable = data.length;
  const notComplete = { closed: false, payload: null, rest: data };
  let payloadOffset = 2;
  if ((dataAvailable - payloadOffset) < 0) return notComplete;
              Severity: Major
              Found in lts/deps/node-inspect/lib/internal/inspect_client.js and 1 other location - About 2 days to fix
              current/deps/node-inspect/lib/internal/inspect_client.js on lines 99..164

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 462.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

              function encodeFrameHybi17(payload) {
  var i;

  const dataLength = payload.length;
              Severity: Major
              Found in lts/deps/node-inspect/lib/internal/inspect_client.js and 1 other location - About 1 day to fix
              current/deps/node-inspect/lib/internal/inspect_client.js on lines 60..97

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 336.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

              function unpackError({ code, message, data }) {
  const err = new Error(`${message} - ${data}`);
  err.code = code;
  Error.captureStackTrace(err, unpackError);
  return err;
              Severity: Major
              Found in lts/deps/node-inspect/lib/internal/inspect_client.js and 1 other location - About 2 hrs to fix
              current/deps/node-inspect/lib/internal/inspect_client.js on lines 53..58

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 75.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status