Sign upLogin

enclose-io/compiler

View on GitHub
Star
lts/lib/internal/crypto/pbkdf2.js

Summary

Maintainability
D
2 days
Test Coverage

Function pbkdf2 has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

function pbkdf2(password, salt, iterations, keylen, digest, callback) {
Severity: Minor
Found in lts/lib/internal/crypto/pbkdf2.js - About 45 mins to fix

    Function pbkdf2Sync has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    function pbkdf2Sync(password, salt, iterations, keylen, digest) {
    Severity: Minor
    Found in lts/lib/internal/crypto/pbkdf2.js - About 35 mins to fix

      Function check has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      function check(password, salt, iterations, keylen, digest) {
      Severity: Minor
      Found in lts/lib/internal/crypto/pbkdf2.js - About 35 mins to fix

        Function pbkdf2 has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        function pbkdf2(password, salt, iterations, keylen, digest, callback) {
  if (typeof digest === 'function') {
    callback = digest;
    digest = undefined;
  }
        Severity: Minor
        Found in lts/lib/internal/crypto/pbkdf2.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        function pbkdf2(password, salt, iterations, keylen, digest, callback) {
  if (typeof digest === 'function') {
    callback = digest;
    digest = undefined;
  }
        Severity: Major
        Found in lts/lib/internal/crypto/pbkdf2.js and 1 other location - About 1 day to fix
        current/lib/internal/crypto/pbkdf2.js on lines 18..42

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 238.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        function pbkdf2Sync(password, salt, iterations, keylen, digest) {
  ({ password, salt, iterations, keylen, digest } =
    check(password, salt, iterations, keylen, digest));
  const keybuf = Buffer.alloc(keylen);
  handleError(_pbkdf2(keybuf, password, salt, iterations, digest), digest);
        Severity: Major
        Found in lts/lib/internal/crypto/pbkdf2.js and 1 other location - About 4 hrs to fix
        current/lib/internal/crypto/pbkdf2.js on lines 44..52

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 117.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status