endpoints/endpoints

View on GitHub
es5/format-jsonapi/index.js

Summary

Maintainability
F
4 days
Test Coverage

Function JsonApiFormat has 193 lines of code (exceeds 25 allowed). Consider refactoring.
Open

var JsonApiFormat = (function () {

  /**
   * The constructor.
   *
Severity: Major
Found in es5/format-jsonapi/index.js - About 7 hrs to fix

    Function JsonApiFormat has a Cognitive Complexity of 40 (exceeds 5 allowed). Consider refactoring.
    Open

    var JsonApiFormat = (function () {
    
      /**
       * The constructor.
       *
    Severity: Minor
    Found in es5/format-jsonapi/index.js - About 6 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function process has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      JsonApiFormat.prototype.process = function process(input) {
        var _this = this;
    
        var opts = arguments.length <= 1 || arguments[1] === undefined ? {} : arguments[1];
        var singleResult = opts.singleResult;
    Severity: Minor
    Found in es5/format-jsonapi/index.js - About 1 hr to fix

      Function format has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        JsonApiFormat.prototype.format = function format(model) {
          var includedRelations = arguments.length <= 1 || arguments[1] === undefined ? [] : arguments[1];
          var mode = arguments.length <= 2 || arguments[2] === undefined ? 'read' : arguments[2];
      
          var store = this.store;
      Severity: Minor
      Found in es5/format-jsonapi/index.js - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          JsonApiFormat.prototype._relationshipData = function _relationshipData(model, relation) {
            var store = this.store;
            var included = store.related(model, relation);
            var data = null;
            if (store.isMany(included)) {
        Severity: Major
        Found in es5/format-jsonapi/index.js and 1 other location - About 1 day to fix
        src/format-jsonapi/index.js on lines 285..310

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 195.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          JsonApiFormat.prototype._relateToOne = function _relateToOne(model, relation, property) {
            var store = this.store;
            var links = this._relationshipLinks(model, relation);
            var id = store.prop(model, property);
            var type = store.type(store.relatedModel(model, relation));
        Severity: Major
        Found in es5/format-jsonapi/index.js and 1 other location - About 3 hrs to fix
        src/format-jsonapi/index.js on lines 229..242

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 113.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          JsonApiFormat.prototype._relateToMany = function _relateToMany(model, relation, included) {
            var relationNodes = relation.split('.');
            var links = this._relationshipLinks(model, relationNodes[0]);
            if (!included) {
              return { links: links };
        Severity: Major
        Found in es5/format-jsonapi/index.js and 1 other location - About 2 hrs to fix
        src/format-jsonapi/index.js on lines 252..262

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 84.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          JsonApiFormat.prototype.relationUrl = function relationUrl(model, relation) {
            return this.baseUrl + '/' + this.store.id(model) + '/relationships/' + relation;
          };
        Severity: Major
        Found in es5/format-jsonapi/index.js and 1 other location - About 1 hr to fix
        es5/format-jsonapi/index.js on lines 60..62

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 63.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          JsonApiFormat.prototype.relatedUrl = function relatedUrl(model, relation) {
            return this.baseUrl + '/' + this.store.id(model) + '/' + relation;
          };
        Severity: Major
        Found in es5/format-jsonapi/index.js and 1 other location - About 1 hr to fix
        es5/format-jsonapi/index.js on lines 71..73

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 63.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status