Sign upLogin

engagementgamelab/CivicSeed

View on GitHub
Star
client/code/admin/admin.js

Summary

Maintainability
C
1 day
Test Coverage

Function setupMonitor has 88 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function setupMonitor () {
  getQuestions()

  $body.on('click', '#players', function () {
    var instance = $(this).attr('data-instance')
Severity: Major
Found in client/code/admin/admin.js - About 3 hrs to fix

    File admin.js has 304 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    'use strict'
/* global ss, $, apprise */

/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * *
    Severity: Minor
    Found in client/code/admin/admin.js - About 3 hrs to fix

      Function showPlayerAnswers has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
      Open

      function showPlayerAnswers (index) {
  var resources = players[index].game.resources
  var numNPC = allQuestions.length
  var html = '<h2>' + players[index].firstName + ' ' + players[index].lastName + '</h2>'
      Severity: Minor
      Found in client/code/admin/admin.js - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function showPlayerAnswers has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function showPlayerAnswers (index) {
  var resources = players[index].game.resources
  var numNPC = allQuestions.length
  var html = '<h2>' + players[index].firstName + ' ' + players[index].lastName + '</h2>'
      Severity: Minor
      Found in client/code/admin/admin.js - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          $body.on('click', '.stopGameButton', function () {
    var instance = $(this).attr('data-instance')
    toggleGame(instance, false)
  })
        Severity: Minor
        Found in client/code/admin/admin.js and 1 other location - About 30 mins to fix
        client/code/admin/admin.js on lines 101..104

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 45.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          $body.on('click', '.startGameButton', function () {
    var instance = $(this).attr('data-instance')
    toggleGame(instance, true)
  })
        Severity: Minor
        Found in client/code/admin/admin.js and 1 other location - About 30 mins to fix
        client/code/admin/admin.js on lines 96..99

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 45.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status