Sign upLogin

engagementgamelab/CivicSeed

View on GitHub
Star
client/code/game/game.audio.js

Summary

Maintainability
F
3 days
Test Coverage

File game.audio.js has 400 lines of code (exceeds 250 allowed). Consider refactoring.
Open

'use strict'
/* global ss, CivicSeed, $game, Howl, Howler */

var _soundtracks = []
var _triggerFx = null
Severity: Minor
Found in client/code/game/game.audio.js - About 5 hrs to fix

    exports has 22 functions (exceeds 20 allowed). Consider refactoring.
    Open

    var $audio = module.exports = {

  ready: false,
  isMute: false,
    Severity: Minor
    Found in client/code/game/game.audio.js - About 2 hrs to fix

      Function loadEnvironmentOnceFx has 37 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        loadEnvironmentOnceFx: function () {
    var mp3 = _musicPath + 'environmentonce.mp3?VERSION='
    var ogg = _musicPath + '/ogg/environmentonce.ogg?VERSION='

    if (_extension) {
      Severity: Minor
      Found in client/code/game/game.audio.js - About 1 hr to fix

        Function loadTriggerFx has 34 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          loadTriggerFx: function () {
    var mp3 = _musicPath + 'triggers.mp3?VERSION='
    var ogg = _musicPath + '/ogg/triggers.ogg?VERSION='

    if (_extension) {
        Severity: Minor
        Found in client/code/game/game.audio.js - About 1 hr to fix

          Function update has 32 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            update: function () {
    var trackNum = whichTrack()
    var message = 'Entering '

    if (_soundtracks[trackNum]._loaded && trackNum !== _currentTrack && !_midTransition) {
          Severity: Minor
          Found in client/code/game/game.audio.js - About 1 hr to fix

            Function loadOtherTrack has 27 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              loadOtherTrack: function (track, num) {
    if (track !== num) {
      var mp3 = _musicPath + track + '.mp3?VERSION='
      var ogg = _musicPath + '/ogg/' + '.ogg?VERSION='
            Severity: Minor
            Found in client/code/game/game.audio.js - About 1 hr to fix

              Function loadEnvironmentLoopFx has 26 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                loadEnvironmentLoopFx: function () {
    var mp3 = _musicPath + 'environmentloop.mp3?VERSION='
    var ogg = _musicPath + '/ogg/environmentloop.ogg?VERSION='

    if (_extension) {
              Severity: Minor
              Found in client/code/game/game.audio.js - About 1 hr to fix

                Function loadOtherTrack has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                Open

                  loadOtherTrack: function (track, num) {
    if (track !== num) {
      var mp3 = _musicPath + track + '.mp3?VERSION='
      var ogg = _musicPath + '/ogg/' + '.ogg?VERSION='
                Severity: Minor
                Found in client/code/game/game.audio.js - About 55 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function update has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                  update: function () {
    var trackNum = whichTrack()
    var message = 'Entering '

    if (_soundtracks[trackNum]._loaded && trackNum !== _currentTrack && !_midTransition) {
                Severity: Minor
                Found in client/code/game/game.audio.js - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function checkEnvironmentLoopFx has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                  checkEnvironmentLoopFx: function () {
    var numPlaces = _environmentLoopFxPlaces.length
    var p = 0

    while (p < numPlaces) {
                Severity: Minor
                Found in client/code/game/game.audio.js - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function checkEnvironmentOnceFx has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                  checkEnvironmentOnceFx: function () {
    var numPlaces = _environmentOnceFxPlaces.length
    var p = 0

    while (p < numPlaces) {
                Severity: Minor
                Found in client/code/game/game.audio.js - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Identical blocks of code found in 5 locations. Consider refactoring.
                Open

                    if (_extension) {
      mp3 += _extension
      ogg += _extension
    } else {
      mp3 += Math.round(Math.random(1) * 1000000000)
                Severity: Major
                Found in client/code/game/game.audio.js and 4 other locations - About 2 hrs to fix
                client/code/game/game.audio.js on lines 113..119
                client/code/game/game.audio.js on lines 144..150
                client/code/game/game.audio.js on lines 212..218
                client/code/game/game.audio.js on lines 242..248

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 79.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 5 locations. Consider refactoring.
                Open

                    if (_extension) {
      mp3 += _extension
      ogg += _extension
    } else {
      mp3 += Math.round(Math.random(1) * 1000000000)
                Severity: Major
                Found in client/code/game/game.audio.js and 4 other locations - About 2 hrs to fix
                client/code/game/game.audio.js on lines 113..119
                client/code/game/game.audio.js on lines 144..150
                client/code/game/game.audio.js on lines 174..180
                client/code/game/game.audio.js on lines 242..248

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 79.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 5 locations. Consider refactoring.
                Open

                      if (_extension) {
        mp3 += _extension
        ogg += _extension
      } else {
        mp3 += Math.round(Math.random(1) * 1000000000)
                Severity: Major
                Found in client/code/game/game.audio.js and 4 other locations - About 2 hrs to fix
                client/code/game/game.audio.js on lines 113..119
                client/code/game/game.audio.js on lines 174..180
                client/code/game/game.audio.js on lines 212..218
                client/code/game/game.audio.js on lines 242..248

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 79.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 5 locations. Consider refactoring.
                Open

                    if (_extension) {
      mp3 += _extension
      ogg += _extension
    } else {
      mp3 += Math.round(Math.random(1) * 1000000000)
                Severity: Major
                Found in client/code/game/game.audio.js and 4 other locations - About 2 hrs to fix
                client/code/game/game.audio.js on lines 144..150
                client/code/game/game.audio.js on lines 174..180
                client/code/game/game.audio.js on lines 212..218
                client/code/game/game.audio.js on lines 242..248

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 79.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 5 locations. Consider refactoring.
                Open

                    if (_extension) {
      mp3 += _extension
      ogg += _extension
    } else {
      mp3 += Math.round(Math.random(1) * 1000000000)
                Severity: Major
                Found in client/code/game/game.audio.js and 4 other locations - About 2 hrs to fix
                client/code/game/game.audio.js on lines 113..119
                client/code/game/game.audio.js on lines 144..150
                client/code/game/game.audio.js on lines 174..180
                client/code/game/game.audio.js on lines 212..218

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 79.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                  {location: {x: 105, y: 30}, sounds: ['churchBells', 'townBells', 'chatter', 'bird2', 'bird3'], prox: {x: 20, y: 20}, chance: 0.1},
                Severity: Minor
                Found in client/code/game/game.audio.js and 1 other location - About 45 mins to fix
                client/code/game/game.audio.js on lines 35..35

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 50.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                  {location: {x: 105, y: 90}, sounds: ['chickens', 'sheep1', 'sheep2', 'horse', 'bird3'], prox: {x: 35, y: 30}, chance: 0.15},
                Severity: Minor
                Found in client/code/game/game.audio.js and 1 other location - About 45 mins to fix
                client/code/game/game.audio.js on lines 34..34

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 50.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status