Sign upLogin

engagementgamelab/CivicSeed

View on GitHub
Star
client/code/game/game.map.js

Summary

Maintainability
D
2 days
Test Coverage

Function transitionMap has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
Open

  transitionMap: function (stepNumber) {
    // --------RIGHT------------
    // go thru current array and shift everthing
    if ($map.stepDirection === 'right') {
      // shift all except last column
Severity: Minor
Found in client/code/game/game.map.js - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File game.map.js has 298 lines of code (exceeds 250 allowed). Consider refactoring.
Open

'use strict'
/* global ss, $, $game */

var _nextTiles = []
var _leftEdge = 0
Severity: Minor
Found in client/code/game/game.map.js - About 3 hrs to fix

    Function transitionMap has 62 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      transitionMap: function (stepNumber) {
    // --------RIGHT------------
    // go thru current array and shift everthing
    if ($map.stepDirection === 'right') {
      // shift all except last column
    Severity: Major
    Found in client/code/game/game.map.js - About 2 hrs to fix

      Function getTiles has 45 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        getTiles: function (data, callback) {
    $map.dataLoaded = false
    var x1 = data.x
    var y1 = data.y
    var x2 = data.x + data.numX
      Severity: Minor
      Found in client/code/game/game.map.js - About 1 hr to fix

        Function calculateNext has 42 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          calculateNext: function (x, y) {
    var getThisManyX
    var getThisManyY
    var getThisX
    var getThisY
        Severity: Minor
        Found in client/code/game/game.map.js - About 1 hr to fix

          Function newBomb has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

            newBomb: function (bombed, id) {
    for (var b = 0; b < bombed.length; b += 1) {
      // only add it to render list if it is on current screen
      var loc = $map.masterToLocal(bombed[b].x, bombed[b].y)
      var curTile = null
          Severity: Minor
          Found in client/code/game/game.map.js - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                for (var i = $game.VIEWPORT_WIDTH - 1; i > 0; i--) {
        for (var j = 0; j < $game.VIEWPORT_HEIGHT; j++) {
          $map.currentTiles[i][j] = $map.currentTiles[ i - 1 ][j]
        }
      }
          Severity: Major
          Found in client/code/game/game.map.js and 1 other location - About 1 hr to fix
          client/code/game/game.map.js on lines 171..175

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 66.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                for (var j = 0; j < $game.VIEWPORT_HEIGHT - 1; j++) {
        for (var i = 0; i < $game.VIEWPORT_WIDTH; i++) {
          $map.currentTiles[i][j] = $map.currentTiles[i][j + 1]
        }
      }
          Severity: Major
          Found in client/code/game/game.map.js and 1 other location - About 1 hr to fix
          client/code/game/game.map.js on lines 210..214

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 66.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                for (var j = $game.VIEWPORT_HEIGHT - 1; j > 0; j--) {
        for (var i = 0; i < $game.VIEWPORT_WIDTH; i++) {
          $map.currentTiles[i][j] = $map.currentTiles[i][j - 1]
        }
      }
          Severity: Major
          Found in client/code/game/game.map.js and 1 other location - About 1 hr to fix
          client/code/game/game.map.js on lines 229..233

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 66.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                for (var i = 0; i < $game.VIEWPORT_WIDTH - 1; i++) {
        for (var j = 0; j < $game.VIEWPORT_HEIGHT; j++) {
          $map.currentTiles[i][j] = $map.currentTiles[ i + 1 ][j]
        }
      }
          Severity: Major
          Found in client/code/game/game.map.js and 1 other location - About 1 hr to fix
          client/code/game/game.map.js on lines 190..194

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 66.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status