Sign upLogin

engagementgamelab/CivicSeed

View on GitHub
Star
client/code/game/game.npc.js

Summary

Maintainability
F
4 days
Test Coverage

Function exports has a Cognitive Complexity of 58 (exceeds 5 allowed). Consider refactoring.
Open

module.exports = (function () {
  var _npc = {
    data: {},

    // Add an npc to the data object
Severity: Minor
Found in client/code/game/game.npc.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function exports has 217 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = (function () {
  var _npc = {
    data: {},

    // Add an npc to the data object
Severity: Major
Found in client/code/game/game.npc.js - About 1 day to fix

    File game.npc.js has 343 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    'use strict'
/* global ss, $, $game */

/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * *
    Severity: Minor
    Found in client/code/game/game.npc.js - About 4 hrs to fix

      Function showSpeechBubble has 77 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          showSpeechBubble: function (speaker, messages, prompt, callback) {
      var el = document.getElementById('speech-bubble')
      var $el = $(el) // Cache jQuery reference
      var hasPrompt = false
      var isMultiline = false
      Severity: Major
      Found in client/code/game/game.npc.js - About 3 hrs to fix

        Function getSmalltalk has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

        Npc.prototype.getSmalltalk = function () {
  var dialog = ''
  var place = ''

  if (this.isHolding) {
        Severity: Minor
        Found in client/code/game/game.npc.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function getSmalltalk has 34 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        Npc.prototype.getSmalltalk = function () {
  var dialog = ''
  var place = ''

  if (this.isHolding) {
        Severity: Minor
        Found in client/code/game/game.npc.js - About 1 hr to fix

          Function activate has 33 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              activate: function (npcId) {
      var MASTER_NPC_ID = 64
      var npc = this.get(npcId)
      var botanistState = $game.$botanist.getState()
          Severity: Minor
          Found in client/code/game/game.npc.js - About 1 hr to fix

            Function Npc has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            function Npc (data) {
  this.name = data.name
  this.id = data.id
  this.sprite = data.sprite
  this.level = data.level
            Severity: Minor
            Found in client/code/game/game.npc.js - About 1 hr to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                        if ($game.$player.checkForCompletedResource(4001) === true ||
              $game.$player.checkForCompletedResource(4002) === true ||
              $game.$player.checkForCompletedResource(4003) === true) {
              Severity: Major
              Found in client/code/game/game.npc.js and 1 other location - About 1 hr to fix
              client/code/game/game.resources.js on lines 741..743

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 57.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                      $el.find('.no-button').on('click', function (e) {
          e.stopImmediatePropagation()
          self.hideSpeechBubble(callback)
        }).show()
              Severity: Major
              Found in client/code/game/game.npc.js and 2 other locations - About 55 mins to fix
              client/code/game/game.npc.js on lines 420..423
              client/code/game/game.npc.js on lines 434..437

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 53.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                          $el.find('.close-button').on('click', function (e) {
              e.stopImmediatePropagation()
              self.hideSpeechBubble(callback)
            }).show()
              Severity: Major
              Found in client/code/game/game.npc.js and 2 other locations - About 55 mins to fix
              client/code/game/game.npc.js on lines 434..437
              client/code/game/game.npc.js on lines 440..443

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 53.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                      $el.find('.yes-button').on('click', function (e) {
          e.stopImmediatePropagation()
          self.hideSpeechBubble(prompt)
        }).show()
              Severity: Major
              Found in client/code/game/game.npc.js and 2 other locations - About 55 mins to fix
              client/code/game/game.npc.js on lines 420..423
              client/code/game/game.npc.js on lines 440..443

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 53.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  clear: function () {
      $.each(_npc.data, function (key, npc) {
        npc.clear()
      })
    },
              Severity: Minor
              Found in client/code/game/game.npc.js and 1 other location - About 30 mins to fix
              client/code/game/game.npc.js on lines 251..255

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 45.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  update: function () {
      $.each(_npc.data, function (key, npc) {
        npc.update()
      })
    },
              Severity: Minor
              Found in client/code/game/game.npc.js and 1 other location - About 30 mins to fix
              client/code/game/game.npc.js on lines 258..262

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 45.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status