Sign upLogin

engagementgamelab/CivicSeed

View on GitHub
Star
client/code/game/game.skins.js

Summary

Maintainability
C
1 day
Test Coverage

Function renderSkinformation has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

function renderSkinformation () {
  var playerSkin = $game.$player.getSkinSuit()
  var skins = data.outfits
  var head = playerSkin.head
  var torso = playerSkin.torso
Severity: Minor
Found in client/code/game/game.skins.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function renderSkinventoryUI has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function renderSkinventoryUI () {
  var playerSkin = $game.$player.getSkinSuit()
  var unlocked = $game.$player.getSkinventory()
  var skins = getSets()
Severity: Minor
Found in client/code/game/game.skins.js - About 1 hr to fix

    Function renderSkinformation has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function renderSkinformation () {
  var playerSkin = $game.$player.getSkinSuit()
  var skins = data.outfits
  var head = playerSkin.head
  var torso = playerSkin.torso
    Severity: Minor
    Found in client/code/game/game.skins.js - About 1 hr to fix

      Function unlockSkin has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

      function unlockSkin (skin, part) {
  var skinventory = $game.$player.getSkinventory()

  if (part !== undefined) {
    // If part already exists, skip.
      Severity: Minor
      Found in client/code/game/game.skins.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function renderSkinventoryUI has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

      function renderSkinventoryUI () {
  var playerSkin = $game.$player.getSkinSuit()
  var unlocked = $game.$player.getSkinventory()
  var skins = getSets()
      Severity: Minor
      Found in client/code/game/game.skins.js - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        $game.$render.createCanvasForPlayer($game.$player.id, $game.$player.getSkinSuit(), $game.$player.getColorIndex())
      Severity: Minor
      Found in client/code/game/game.skins.js and 1 other location - About 40 mins to fix
      client/code/game/game.main.js on lines 633..633

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 49.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          if (!_.contains(skinventory.legs, skin)) {
      skinventory.legs.push(skin)
      $game.addBadgeCount('.hud-skinventory', 1)
    }
      Severity: Minor
      Found in client/code/game/game.skins.js and 1 other location - About 40 mins to fix
      client/code/game/game.skins.js on lines 63..66

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 49.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          if (!_.contains(skinventory.torso, skin)) {
      skinventory.torso.push(skin)
      $game.addBadgeCount('.hud-skinventory', 1)
    }
      Severity: Minor
      Found in client/code/game/game.skins.js and 1 other location - About 40 mins to fix
      client/code/game/game.skins.js on lines 67..70

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 49.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status