engagementgamelab/CivicSeed

View on GitHub
client/code/system/underscore.js

Summary

Maintainability
F
4 days
Test Coverage

File underscore.js has 931 lines of code (exceeds 250 allowed). Consider refactoring.
Open

//     Underscore.js 1.6.0
//     http://underscorejs.org
//     (c) 2009-2014 Jeremy Ashkenas, DocumentCloud and Investigative Reporters & Editors
//     Underscore may be freely distributed under the MIT license.

Severity: Major
Found in client/code/system/underscore.js - About 2 days to fix

    Function eq has 59 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      var eq = function(a, b, aStack, bStack) {
        // Identical objects are equal. `0 === -0`, but they aren't identical.
        // See the [Harmony `egal` proposal](http://wiki.ecmascript.org/doku.php?id=harmony:egal).
        if (a === b) return a !== 0 || 1 / a == 1 / b;
        // A strict comparison is necessary because `null == undefined`.
    Severity: Major
    Found in client/code/system/underscore.js - About 2 hrs to fix

      Function template has 41 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        _.template = function(text, data, settings) {
          var render;
          settings = _.defaults({}, settings, _.templateSettings);
      
          // Combine delimiters into one regular expression via alternation.
      Severity: Minor
      Found in client/code/system/underscore.js - About 1 hr to fix

        Function debounce has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          _.debounce = function(func, wait, immediate) {
            var timeout, args, context, timestamp, result;
        
            var later = function() {
              var last = _.now() - timestamp;
        Severity: Minor
        Found in client/code/system/underscore.js - About 1 hr to fix

          Function throttle has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            _.throttle = function(func, wait, options) {
              var context, args, result;
              var timeout = null;
              var previous = 0;
              options || (options = {});
          Severity: Minor
          Found in client/code/system/underscore.js - About 1 hr to fix

            Consider simplifying this complex logical expression.
            Open

                if (aCtor !== bCtor && !(_.isFunction(aCtor) && (aCtor instanceof aCtor) &&
                                         _.isFunction(bCtor) && (bCtor instanceof bCtor))
                                    && ('constructor' in a && 'constructor' in b)) {
                  return false;
                }
            Severity: Major
            Found in client/code/system/underscore.js - About 1 hr to fix

              Avoid too many return statements within this function.
              Open

                    if (aStack[length] == a) return bStack[length] == b;
              Severity: Major
              Found in client/code/system/underscore.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                    return -1;
                Severity: Major
                Found in client/code/system/underscore.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                        return false;
                  Severity: Major
                  Found in client/code/system/underscore.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                        return result;
                    Severity: Major
                    Found in client/code/system/underscore.js - About 30 mins to fix

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                          if (!iterator && _.isArray(obj) && obj[0] === +obj[0] && obj.length < 65535) {
                            return Math.min.apply(Math, obj);
                          }
                      Severity: Major
                      Found in client/code/system/underscore.js and 1 other location - About 1 hr to fix
                      client/code/system/underscore.js on lines 255..257

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 67.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                          if (!iterator && _.isArray(obj) && obj[0] === +obj[0] && obj.length < 65535) {
                            return Math.max.apply(Math, obj);
                          }
                      Severity: Major
                      Found in client/code/system/underscore.js and 1 other location - About 1 hr to fix
                      client/code/system/underscore.js on lines 271..273

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 67.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                          each(obj, function(value, index, list) {
                            var computed = iterator ? iterator.call(context, value, index, list) : value;
                            if (computed < lastComputed) {
                              result = value;
                              lastComputed = computed;
                      Severity: Major
                      Found in client/code/system/underscore.js and 1 other location - About 1 hr to fix
                      client/code/system/underscore.js on lines 259..265

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 65.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                          if (nativeReduce && obj.reduce === nativeReduce) {
                            if (context) iterator = _.bind(iterator, context);
                            return initial ? obj.reduce(iterator, memo) : obj.reduce(iterator);
                          }
                      Severity: Major
                      Found in client/code/system/underscore.js and 1 other location - About 1 hr to fix
                      client/code/system/underscore.js on lines 133..136

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 65.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                          each(obj, function(value, index, list) {
                            var computed = iterator ? iterator.call(context, value, index, list) : value;
                            if (computed > lastComputed) {
                              result = value;
                              lastComputed = computed;
                      Severity: Major
                      Found in client/code/system/underscore.js and 1 other location - About 1 hr to fix
                      client/code/system/underscore.js on lines 275..281

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 65.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                          if (nativeReduceRight && obj.reduceRight === nativeReduceRight) {
                            if (context) iterator = _.bind(iterator, context);
                            return initial ? obj.reduceRight(iterator, memo) : obj.reduceRight(iterator);
                          }
                      Severity: Major
                      Found in client/code/system/underscore.js and 1 other location - About 1 hr to fix
                      client/code/system/underscore.js on lines 112..115

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 65.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      There are no issues that match your filters.

                      Category
                      Status