Sign upLogin

engagementgamelab/CivicSeed

View on GitHub
Star
server/rpc/admin/startup.js

Summary

Maintainability
D
2 days
Test Coverage

Function loadUsers has 86 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  loadUsers: function (req, res, ss) {
    var userData = require(rootDir + '/data/users.json')
    var userDataCopy = _JSONClone(userData)
    var numDemoUsers = 16
    var demoUsers = []
Severity: Major
Found in server/rpc/admin/startup.js - About 3 hrs to fix

    Function hashDemoData has 60 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function hashDemoData (i) {
      if (i < numDemoUsers) {
        accountHelpers.hashPassword('demo', function (hashedPassword) {
          // create demo users
          var d = {
    Severity: Major
    Found in server/rpc/admin/startup.js - About 2 hrs to fix

      File startup.js has 264 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      'use strict'

var rootDir = process.cwd()
var winston = require('winston')
      Severity: Minor
      Found in server/rpc/admin/startup.js - About 2 hrs to fix

        Function loadTiles has 49 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          loadTiles: function (req, res, ss) {
    var tileData = require(rootDir + '/data/tiles.json')

    // Set up tile data object
    var data = tileData.layers // This is an array of unnamed objects, we want to name them
        Severity: Minor
        Found in server/rpc/admin/startup.js - About 1 hr to fix

          Function actions has 35 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          exports.actions = function (req, res, ss) {
  req.use('session')
  req.use('account.authenticated')

  return {
          Severity: Minor
          Found in server/rpc/admin/startup.js - About 1 hr to fix

            Function loadData has 29 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                loadData: function (dataType) {
      if (req.session.role && req.session.role === 'superadmin') {
        winston.info(filename + ' Loading data for collection: '.magenta + dataType.yellow.underline + ' ...'.magenta)

        switch (dataType) {
            Severity: Minor
            Found in server/rpc/admin/startup.js - About 1 hr to fix

              Function loadUsers has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                loadUsers: function (req, res, ss) {
    var userData = require(rootDir + '/data/users.json')
    var userDataCopy = _JSONClone(userData)
    var numDemoUsers = 16
    var demoUsers = []
              Severity: Minor
              Found in server/rpc/admin/startup.js - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function actions has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

              exports.actions = function (req, res, ss) {
  req.use('session')
  req.use('account.authenticated')

  return {
              Severity: Minor
              Found in server/rpc/admin/startup.js - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  dbActions.resetDefaultData(colorModel, function (err) {
      if (err) {
        // Placeholder for error handling
      } else {
        dbActions.saveDocuments(colorModel, colors, function () {
              Severity: Major
              Found in server/rpc/admin/startup.js and 1 other location - About 1 hr to fix
              server/rpc/admin/startup.js on lines 292..300

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 56.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  dbActions.resetDefaultData(gameModel, function (err) {
      if (err) {
        // Placeholder for error handling
      } else {
        dbActions.saveDocuments(gameModel, gameData, function () {
              Severity: Major
              Found in server/rpc/admin/startup.js and 1 other location - About 1 hr to fix
              server/rpc/admin/startup.js on lines 246..254

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 56.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                            skinSuit: {
                head: 'basic',
                torso: 'basic',
                legs: 'basic',
                unlocked: {
              Severity: Minor
              Found in server/rpc/admin/startup.js and 1 other location - About 40 mins to fix
              server/rpc/admin/invitecodes.js on lines 77..86

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 48.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status