Sign upLogin

engagementgamelab/CivicSeed

View on GitHub
Star
server/rpc/shared/account.js

Summary

Maintainability
F
3 days
Test Coverage

Function actions has 261 lines of code (exceeds 25 allowed). Consider refactoring.
Open

exports.actions = function (req, res, ss) {
  req.use('session')

  var UserModel = ss.service.db.model('User')
  var GameModel = ss.service.db.model('Game')
Severity: Major
Found in server/rpc/shared/account.js - About 1 day to fix

    File account.js has 280 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    'use strict'

var rootDir = process.cwd()
var bcrypt = require('bcrypt')
var xkcd = require('xkcd-pwgen')
    Severity: Minor
    Found in server/rpc/shared/account.js - About 2 hrs to fix

      Function checkGameSession has 51 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          checkGameSession: function () {
      dbHelpers.checkGameActive(req.session.game.instanceName, function (active) {
        if (active) {
          UserModel.findById(req.session.userId, function (error, user) {
            if (error || !user) {
      Severity: Major
      Found in server/rpc/shared/account.js - About 2 hrs to fix

        Function actions has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
        Open

        exports.actions = function (req, res, ss) {
  req.use('session')

  var UserModel = ss.service.db.model('User')
  var GameModel = ss.service.db.model('Game')
        Severity: Minor
        Found in server/rpc/shared/account.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function deAuthenticate has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            deAuthenticate: function () {
      winston.info('Deauthenticating...')
      // console.log(req.session.firstName, req.session.email, req.session.role, req.session.gameChannel, req.session.userId);

      var sessionId = req.sessionId
        Severity: Minor
        Found in server/rpc/shared/account.js - About 1 hr to fix

          Function remindMeMyPassword has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              remindMeMyPassword: function (email) {
      UserModel.findOne({ email: email }, function (err, user) {
        if (!err && user) {
          // TODO THIS AUTO RESETS without creds!!
          var password = xkcd.generatePassword()
          Severity: Minor
          Found in server/rpc/shared/account.js - About 1 hr to fix

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                return {
      id: req.session.userId,
      firstName: req.session.firstName,
      lastName: req.session.lastName,
      email: req.session.email,
            Severity: Major
            Found in server/rpc/shared/account.js and 1 other location - About 4 hrs to fix
            server/rpc/shared/account.js on lines 133..143

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 119.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                    res({
          id: req.session.userId,
          firstName: req.session.firstName,
          lastName: req.session.lastName,
          email: req.session.email,
            Severity: Major
            Found in server/rpc/shared/account.js and 1 other location - About 4 hrs to fix
            server/rpc/shared/account.js on lines 40..50

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 119.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                      user.save(function (error) {
            if (error) {
              console.log('Error making active session ID null in mongodb'.red)
            } else {
              console.log('Active session ID made null in mongodb'.green)
            Severity: Major
            Found in server/rpc/shared/account.js and 1 other location - About 1 hr to fix
            server/rpc/shared/account.js on lines 224..230

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 58.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                      user.save(function (error) {
            if (error) {
              console.error('Error saving active session ID to mongodb'.red)
            } else {
              console.log('Saved a new activeSessionID'.green)
            Severity: Major
            Found in server/rpc/shared/account.js and 1 other location - About 1 hr to fix
            server/rpc/shared/account.js on lines 105..111

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 58.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status