engine-bay/sheet-functions

View on GitHub

Showing 3 of 4 total issues

Method VLOOKUP has a Cognitive Complexity of 28 (exceeds 20 allowed). Consider refactoring.
Open

        public static string VLOOKUP(string lookupValue, DataTable dataTable, int index, int sortDirection)
        {
            ArgumentNullException.ThrowIfNull(dataTable);

            foreach (DataColumn col in dataTable.Columns)
Severity: Minor
Found in EngineBay.SheetFunctions/VLookup.cs - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method VLOOKUP has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        public static string VLOOKUP(string lookupValue, DataTable dataTable, int index, int sortDirection)
        {
            ArgumentNullException.ThrowIfNull(dataTable);

            foreach (DataColumn col in dataTable.Columns)
Severity: Minor
Found in EngineBay.SheetFunctions/VLookup.cs - About 1 hr to fix

    Avoid deeply nested control flow statements.
    Open

                                    if (value == lookupValue)
                                    {
                                        var offsetIndex = index - 1; // because excel stats at 1, not zero
                                        var desiredColumnName = dataTable.Columns[offsetIndex].ColumnName;
                                        var desiredValue = row[desiredColumnName].ToString();
    Severity: Major
    Found in EngineBay.SheetFunctions/VLookup.cs - About 45 mins to fix
      Severity
      Category
      Status
      Source
      Language