Sign upLogin

enhancv/mongoose-subscriptions

View on GitHub
Star

Showing 6 of 20 total issues

File Customer.js has 272 lines of code (exceeds 250 allowed). Consider refactoring.
Open

const mongoose = require("mongoose");
const Address = require("./Address");
const PaymentMethod = require("./PaymentMethod");
const Subscription = require("./Subscription");
const Transaction = require("./Transaction");
Severity: Minor
Found in src/Schema/Customer.js - About 2 hrs to fix

    Consider simplifying this complex logical expression.
    Open

            if (this.isTrial) {
            this.firstBillingDate =
                this.firstBillingDate ||
                addTrial(this.trialDuration, this.trialDurationUnit, this.createdAt);
            this.nextBillingDate = this.nextBillingDate || this.firstBillingDate;
    Severity: Critical
    Found in src/Schema/Subscription.js - About 2 hrs to fix

      Function addSubscription has 39 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      Customer.method("addSubscription", function addSubscription(
    plan,
    paymentMethod,
    descriptor,
    activeDate
      Severity: Minor
      Found in src/Schema/Customer.js - About 1 hr to fix

        Function addSubscription has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

        Customer.method("addSubscription", function addSubscription(
    plan,
    paymentMethod,
    descriptor,
    activeDate
        Severity: Minor
        Found in src/Schema/Customer.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this function.
        Open

            return null;
        Severity: Major
        Found in src/Schema/Coupon.js - About 30 mins to fix

          Function initializeLocalDates has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

          Subscription.method("initializeDates", function initializeLocalDates() {
    if (this.processor.state === ProcessorItem.LOCAL) {
        if (this.isTrial) {
            this.firstBillingDate =
                this.firstBillingDate ||
          Severity: Minor
          Found in src/Schema/Subscription.js - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language