Sign upLogin

enricostara/telegram.link

View on GitHub
Star
lib/api/messages.js

Summary

Maintainability
B
6 hrs
Test Coverage

Function getHistory has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

Messages.prototype.getHistory = function (peer, offset, max_id, limit, callback) {
Severity: Minor
Found in lib/api/messages.js - About 35 mins to fix

    Function readHistory has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    Messages.prototype.readHistory = function (peer, max_id, offset, read_contents, callback) {
    Severity: Minor
    Found in lib/api/messages.js - About 35 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      Messages.prototype.readHistory = function (peer, max_id, offset, read_contents, callback) {

    read_contents = read_contents === false ? new api.type.BoolFalse() :
        ( read_contents === true ? new api.type.BoolTrue() : read_contents);
      Severity: Major
      Found in lib/api/messages.js and 1 other location - About 2 hrs to fix
      lib/api/account.js on lines 40..46

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 92.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

      Messages.prototype.sendMessage = function (peer, message, random_id, callback) {
    return utility.callService(api.service.messages.sendMessage, this.client, this.client._channel, callback, arguments);
};
      Severity: Major
      Found in lib/api/messages.js and 3 other locations - About 1 hr to fix
      lib/api/auth.js on lines 88..90
      lib/api/messages.js on lines 40..42
      lib/api/updates.js on lines 53..55

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 62.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

      Messages.prototype.getDialogs = function (offset, max_id, limit, callback) {
    return utility.callService(api.service.messages.getDialogs, this.client, this.client._channel, callback, arguments);
};
      Severity: Major
      Found in lib/api/messages.js and 3 other locations - About 1 hr to fix
      lib/api/auth.js on lines 88..90
      lib/api/messages.js on lines 121..123
      lib/api/updates.js on lines 53..55

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 62.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status