Sign upLogin

enygma/yubikey

View on GitHub
Star

Showing 3 of 3 total issues

Validate has 23 functions (exceeds 20 allowed). Consider refactoring.
Open

class Validate
{
    /**
     * Yubico API hosts
     * @var array
Severity: Minor
Found in src/Yubikey/Validate.php - About 2 hrs to fix

    Method request has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function request(\Yubikey\RequestCollection $requests)
    {
        $responses = new \Yubikey\ResponseCollection();
        $startTime = microtime(true);
        $multi = curl_multi_init();
    Severity: Minor
    Found in src/Yubikey/Client.php - About 1 hr to fix

      Function success has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          public function success($first = false)
    {
        $success = false;
        if ($first === true) {
            // Sort them by timestamp, pop the first one and return pass/fail
      Severity: Minor
      Found in src/Yubikey/ResponseCollection.php - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language