Sign upLogin

epam/miew

View on GitHub
Star
packages/miew/src/ComplexVisualEdit.js

Summary

Maintainability
F
3 days
Test Coverage

File ComplexVisualEdit.js has 314 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import logger from './utils/logger'
import gfxutils from './gfx/gfxutils'
import './gfx/modes'
import { Group, Matrix4, Object3D, Vector3 } from 'three'
Severity: Minor
Found in packages/miew/src/ComplexVisualEdit.js - About 3 hrs to fix

    Function begin has 50 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      begin() {
    const visual = this._complexVisual
    const selection = this._complexVisual.getSelectionGeo()

    const atoms = this._getSelectionBorderAtoms()
    Severity: Minor
    Found in packages/miew/src/ComplexVisualEdit.js - About 2 hrs to fix

      Function getAltObj has 49 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        getAltObj() {
    const res = {
      objects: [],
      pivot: new Vector3(0, 0, 0)
    }
      Severity: Minor
      Found in packages/miew/src/ComplexVisualEdit.js - About 1 hr to fix

        Function _resetComponentTransform has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
        Open

          _resetComponentTransform() {
    const visual = this._complexVisual
    const selection = this._complexVisual.getSelectionGeo()
    let i
    let j
        Severity: Minor
        Found in packages/miew/src/ComplexVisualEdit.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Consider simplifying this complex logical expression.
        Open

            if (
      t &&
      (!(t.position.x === 0 && t.position.y === 0 && t.position.z === 0) ||
        !(
          t.quaternion.x === 0 &&
        Severity: Critical
        Found in packages/miew/src/ComplexVisualEdit.js - About 1 hr to fix

          Function begin has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

            begin() {
    const visual = this._complexVisual
    const selection = this._complexVisual.getSelectionGeo()

    const atoms = this._getSelectionBorderAtoms()
          Severity: Minor
          Found in packages/miew/src/ComplexVisualEdit.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function _resetComponentTransform has 31 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            _resetComponentTransform() {
    const visual = this._complexVisual
    const selection = this._complexVisual.getSelectionGeo()
    let i
    let j
          Severity: Minor
          Found in packages/miew/src/ComplexVisualEdit.js - About 1 hr to fix

            Function getAltObj has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

              getAltObj() {
    const res = {
      objects: [],
      pivot: new Vector3(0, 0, 0)
    }
            Severity: Minor
            Found in packages/miew/src/ComplexVisualEdit.js - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function _traverseComponentGroups has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

            function _traverseComponentGroups(root, component, callback) {
  const { children } = root
  if (!children) {
    return
  }
            Severity: Minor
            Found in packages/miew/src/ComplexVisualEdit.js - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                for (i = 0; i < selection.children.length; ++i) {
      reprNode = selection.children[i]
      for (j = 0; j < reprNode.children.length; ++j) {
        geo = reprNode.children[j]
        if (Object.hasOwn(geo, '_component')) {
            Severity: Major
            Found in packages/miew/src/ComplexVisualEdit.js and 1 other location - About 3 hrs to fix
            packages/miew/src/ComplexVisualEdit.js on lines 177..186

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 114.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                for (i = 0; i < visual.children.length; ++i) {
      reprNode = visual.children[i]
      for (j = 0; j < reprNode.children.length; ++j) {
        geo = reprNode.children[j]
        if (Object.hasOwn(geo, '_component')) {
            Severity: Major
            Found in packages/miew/src/ComplexVisualEdit.js and 1 other location - About 3 hrs to fix
            packages/miew/src/ComplexVisualEdit.js on lines 189..198

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 114.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                  for (let j = 0; j < meshes.length; j++) {
        const m = meshes[j]
        vg.add(m)
        m.position.copy(offset)
      }
            Severity: Major
            Found in packages/miew/src/ComplexVisualEdit.js and 1 other location - About 1 hr to fix
            packages/miew/src/ComplexVisualEdit.js on lines 269..273

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 64.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                  for (let h = 0; h < smeshes.length; h++) {
        const sm = smeshes[h]
        sg.add(sm)
        sm.position.copy(offset)
      }
            Severity: Major
            Found in packages/miew/src/ComplexVisualEdit.js and 1 other location - About 1 hr to fix
            packages/miew/src/ComplexVisualEdit.js on lines 262..266

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 64.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status