packages/miew/src/chem/AutoBond.js

Summary

Maintainability
B
4 hrs
Test Coverage

Function _findPairs has 52 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  _findPairs() {
    const vw = this._complex.getVoxelWorld()
    if (vw === null) {
      return
    }
Severity: Major
Found in packages/miew/src/chem/AutoBond.js - About 2 hrs to fix

    Function _findPairs has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

      _findPairs() {
        const vw = this._complex.getVoxelWorld()
        if (vw === null) {
          return
        }
    Severity: Minor
    Found in packages/miew/src/chem/AutoBond.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _addPair has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      _addPair(atomA, atomB) {
        const bondsA = atomA.bonds
        const indexA = atomA.index
        const indexB = atomB.index
        for (let j = 0, numBonds = bondsA.length; j < numBonds; ++j) {
    Severity: Minor
    Found in packages/miew/src/chem/AutoBond.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _addExistingPairs has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      _addExistingPairs() {
        const atoms = this._complex.getAtoms()
        const numAtoms = atoms.length
        let aInd = 0
        const collection = this._pairCollection
    Severity: Minor
    Found in packages/miew/src/chem/AutoBond.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status