Sign upLogin

epam/miew

View on GitHub
Star
packages/miew/src/gfx/geometries/Instanced2CCylindersGeometry.js

Summary

Maintainability
C
1 day
Test Coverage

Function _init has 70 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  _init(instanceCount, cylinderGeo, useZSprites) {
    this.copy(cylinderGeo)
    this._matVector1 = utils.allocateTyped(
      Float32Array,
      instanceCount * OFFSET_SIZE
Severity: Major
Found in packages/miew/src/gfx/geometries/Instanced2CCylindersGeometry.js - About 2 hrs to fix

    File Instanced2CCylindersGeometry.js has 274 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import {
  Color,
  InstancedBufferAttribute,
  InstancedBufferGeometry,
  Matrix4,
    Severity: Minor
    Found in packages/miew/src/gfx/geometries/Instanced2CCylindersGeometry.js - About 2 hrs to fix

      Function getSubset has 49 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        getSubset(chunkIndices) {
    const info = _prepareCylinderInfo(chunkIndices)
    const cylinderIndices = info.indices
    const instanceCount = cylinderIndices.length
    const geom = new InstancedBufferGeometry()
      Severity: Minor
      Found in packages/miew/src/gfx/geometries/Instanced2CCylindersGeometry.js - About 1 hr to fix

        Function setArrayXYZW has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        function setArrayXYZW(arr, idx, x, y, z, w) {
        Severity: Minor
        Found in packages/miew/src/gfx/geometries/Instanced2CCylindersGeometry.js - About 45 mins to fix

          Function _prepareCylinderInfo has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

          function _prepareCylinderInfo(chunkIndices) {
  chunkIndices.sort(sortNumber)
  const chunksIdx = []
  const cylinderInfo = []
  for (let i = 0, n = chunkIndices.length; i < n; ++i) {
          Severity: Minor
          Found in packages/miew/src/gfx/geometries/Instanced2CCylindersGeometry.js - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function setArrayXYZ has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          function setArrayXYZ(arr, idx, x, y, z) {
          Severity: Minor
          Found in packages/miew/src/gfx/geometries/Instanced2CCylindersGeometry.js - About 35 mins to fix

            Identical blocks of code found in 3 locations. Consider refactoring.
            Open

            function setArrayXYZW(arr, idx, x, y, z, w) {
  arr[idx] = x
  arr[idx + 1] = y
  arr[idx + 2] = z
  arr[idx + 3] = w
            Severity: Major
            Found in packages/miew/src/gfx/geometries/Instanced2CCylindersGeometry.js and 2 other locations - About 1 hr to fix
            packages/miew/src/gfx/geometries/InstancedSpheresGeometry.js on lines 24..29
            packages/miew/src/gfx/geometries/ThickLinesGeometry.js on lines 19..24

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 70.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 4 locations. Consider refactoring.
            Open

            function setArrayXYZ(arr, idx, x, y, z) {
  arr[idx] = x
  arr[idx + 1] = y
  arr[idx + 2] = z
}
            Severity: Major
            Found in packages/miew/src/gfx/geometries/Instanced2CCylindersGeometry.js and 3 other locations - About 55 mins to fix
            packages/miew/src/gfx/geometries/InstancedSpheresGeometry.js on lines 18..22
            packages/miew/src/gfx/geometries/ThickLinesGeometry.js on lines 13..17
            packages/miew/src/gfx/geometries/ThinLinesGeometry.js on lines 10..14

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 54.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status