Sign upLogin

epam/miew

View on GitHub
Star
packages/miew/src/gfx/geometries/IsoSurface.js

Summary

Maintainability
F
5 days
Test Coverage

File IsoSurface.js has 550 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import IsoSurfaceMarchCube from './IsoSurfaceMarchCube'
import utils from '../../utils'
import { BufferAttribute, BufferGeometry, Matrix3, Vector3 } from 'three'

const edgeTable = [
Severity: Major
Found in packages/miew/src/gfx/geometries/IsoSurface.js - About 1 day to fix

    Function setColorVolTex has 160 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      setColorVolTex(colorMap, atomMap, atomWeightMap, visibilitySelector) {
    let i
    let idx
    const numVerts = this._position.length / 3
    const vertices = this._position
    Severity: Major
    Found in packages/miew/src/gfx/geometries/IsoSurface.js - About 6 hrs to fix

      Function setColorVolTex has a Cognitive Complexity of 38 (exceeds 5 allowed). Consider refactoring.
      Open

        setColorVolTex(colorMap, atomMap, atomWeightMap, visibilitySelector) {
    let i
    let idx
    const numVerts = this._position.length / 3
    const vertices = this._position
      Severity: Minor
      Found in packages/miew/src/gfx/geometries/IsoSurface.js - About 5 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _doGridPosNorms has 123 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        _doGridPosNorms(isoValue, step, appendSimple) {
    const vol = this._volumetricData
    const volData = this._volumetricData.getData()
    const dim = vol.getDimensions()
    const xSize = dim[0]
      Severity: Major
      Found in packages/miew/src/gfx/geometries/IsoSurface.js - About 4 hrs to fix

        Function _doGridPosNorms has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
        Open

          _doGridPosNorms(isoValue, step, appendSimple) {
    const vol = this._volumetricData
    const volData = this._volumetricData.getData()
    const dim = vol.getDimensions()
    const xSize = dim[0]
        Severity: Minor
        Found in packages/miew/src/gfx/geometries/IsoSurface.js - About 4 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function vertexFusion has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

          vertexFusion(offset, len) {
    const faceVer = this._indices.length
    const vertices = this._position
    const normals = this._normals
    const oldVerCount = vertices.length | 0
        Severity: Minor
        Found in packages/miew/src/gfx/geometries/IsoSurface.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function _prepareAxesAndDirs has 43 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          _prepareAxesAndDirs() {
    const volData = this._volumetricData

    const cellSize = volData.getCellSize()
        Severity: Minor
        Found in packages/miew/src/gfx/geometries/IsoSurface.js - About 1 hr to fix

          Consider simplifying this complex logical expression.
          Open

              if (
      xDir.x < 0 ||
      xDir.y < 0 ||
      xDir.z < 0 ||
      yDir.x < 0 ||
          Severity: Critical
          Found in packages/miew/src/gfx/geometries/IsoSurface.js - About 1 hr to fix

            Function _polygonize has 32 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              _polygonize(grid, isoLevel, triangles) {
    const { cubeIndex } = grid
    let i = 0
    const arrSize = IsoSurface._arrSize
    const firstIndices = IsoSurface._firstIndices
            Severity: Minor
            Found in packages/miew/src/gfx/geometries/IsoSurface.js - About 1 hr to fix

              Function vertexFusion has 32 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                vertexFusion(offset, len) {
    const faceVer = this._indices.length
    const vertices = this._position
    const normals = this._normals
    const oldVerCount = vertices.length | 0
              Severity: Minor
              Found in packages/miew/src/gfx/geometries/IsoSurface.js - About 1 hr to fix

                Avoid deeply nested control flow statements.
                Open

                            if (gcVal[i] < isoValue) {
              cubeIndex |= 1 << i
            }
                Severity: Major
                Found in packages/miew/src/gfx/geometries/IsoSurface.js - About 45 mins to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                          posMtx.set(
          self._xAxis.x,
          self._yAxis.x,
          self._zAxis.x,
          self._xAxis.y,
                  Severity: Major
                  Found in packages/miew/src/gfx/geometries/IsoSurface.js and 1 other location - About 2 hrs to fix
                  packages/miew/src/gfx/geometries/IsoSurface.js on lines 289..299

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 91.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                          normMtx.set(
          self._xDir.x,
          self._yDir.x,
          self._zDir.x,
          self._xDir.y,
                  Severity: Major
                  Found in packages/miew/src/gfx/geometries/IsoSurface.js and 1 other location - About 2 hrs to fix
                  packages/miew/src/gfx/geometries/IsoSurface.js on lines 277..287

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 91.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status