packages/miew/src/gfx/modes/groups/CartoonHelper.js

Summary

Maintainability
B
5 hrs
Test Coverage

Function _calcPoints has 48 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function _calcPoints(residues, firstIdx, lastIdx, boundaries) {
  const left = boundaries.start
  const right = boundaries.end
  function _prevIdx(idx) {
    return idx > left && residues[idx - 1]._isValid ? idx - 1 : idx
Severity: Minor
Found in packages/miew/src/gfx/modes/groups/CartoonHelper.js - About 1 hr to fix

    Function _addPointsForLoneResidue has 41 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function _addPointsForLoneResidue(centerPoints, topPoints, idx, residue) {
      const nucleic = (residue._type.flags & ResidueType.Flags.NUCLEIC) !== 0
      const nameFrom = nucleic ? "C5'" : 'N'
      const nameTo = nucleic ? "C3'" : 'C'
    
    
    Severity: Minor
    Found in packages/miew/src/gfx/modes/groups/CartoonHelper.js - About 1 hr to fix

      Function _calcPoints has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

      function _calcPoints(residues, firstIdx, lastIdx, boundaries) {
        const left = boundaries.start
        const right = boundaries.end
        function _prevIdx(idx) {
          return idx > left && residues[idx - 1]._isValid ? idx - 1 : idx
      Severity: Minor
      Found in packages/miew/src/gfx/modes/groups/CartoonHelper.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _addPointsForLoneResidue has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      function _addPointsForLoneResidue(centerPoints, topPoints, idx, residue) {
        const nucleic = (residue._type.flags & ResidueType.Flags.NUCLEIC) !== 0
        const nameFrom = nucleic ? "C5'" : 'N'
        const nameTo = nucleic ? "C3'" : 'C'
      
      
      Severity: Minor
      Found in packages/miew/src/gfx/modes/groups/CartoonHelper.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status