Sign upLogin

epam/miew

View on GitHub
Star
packages/miew/src/io/exporters/fbx/FBXInfoExtractor.js

Summary

Maintainability
C
1 day
Test Coverage

File FBXInfoExtractor.js has 302 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import utils from '../../../utils'
import gfxutils from '../../../gfx/gfxutils'
import logger from '../../../utils/logger'

import FBXModel from './FBXModel'
Severity: Minor
Found in packages/miew/src/io/exporters/fbx/FBXInfoExtractor.js - About 3 hrs to fix

    Function _collectCylindersInfo has 50 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      _collectCylindersInfo(mesh) {
    const {
      geometry: {
        attributes: { position, color, color2 },
        index
    Severity: Minor
    Found in packages/miew/src/io/exporters/fbx/FBXInfoExtractor.js - About 2 hrs to fix

      Function _flattenModels has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        _flattenModels() {
    let overallVertsCount = 0
    function shift(x) {
      return x + overallVertsCount
    }
      Severity: Minor
      Found in packages/miew/src/io/exporters/fbx/FBXInfoExtractor.js - About 1 hr to fix

        Function _collectGeoInfo has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          _collectGeoInfo(mesh) {
    const {
      geometry: {
        attributes: { position, color, normal },
        index
        Severity: Minor
        Found in packages/miew/src/io/exporters/fbx/FBXInfoExtractor.js - About 1 hr to fix

          Function _collectSpheresInfo has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            _collectSpheresInfo(mesh) {
    const {
      geometry: {
        attributes: { position, color },
        index
          Severity: Minor
          Found in packages/miew/src/io/exporters/fbx/FBXInfoExtractor.js - About 1 hr to fix

            Function _collectCylindersInfo has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

              _collectCylindersInfo(mesh) {
    const {
      geometry: {
        attributes: { position, color, color2 },
        index
            Severity: Minor
            Found in packages/miew/src/io/exporters/fbx/FBXInfoExtractor.js - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                const {
      geometry: {
        attributes: { position, color, normal },
        index
      },
            Severity: Minor
            Found in packages/miew/src/io/exporters/fbx/FBXInfoExtractor.js and 1 other location - About 30 mins to fix
            packages/miew/src/io/exporters/fbx/FBXInfoExtractor.js on lines 221..227

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 45.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                const {
      geometry: {
        attributes: { position, color, color2 },
        index
      },
            Severity: Minor
            Found in packages/miew/src/io/exporters/fbx/FBXInfoExtractor.js and 1 other location - About 30 mins to fix
            packages/miew/src/io/exporters/fbx/FBXInfoExtractor.js on lines 142..148

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 45.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status