Sign upLogin

epam/miew

View on GitHub
Star
packages/miew/src/ui/ObjectControls.js

Summary

Maintainability
F
1 wk
Test Coverage

File ObjectControls.js has 729 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import Timer from '../Timer'
import settings from '../settings'
import EventDispatcher from '../utils/EventDispatcher'
import { Matrix4, Quaternion, Vector2, Vector3 } from 'three'
Severity: Major
Found in packages/miew/src/ui/ObjectControls.js - About 1 day to fix

    Function ObjectControls has 152 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function ObjectControls(object, objectPivot, camera, domElement, getAltObj) {
  EventDispatcher.call(this)
  const self = this

  this.object = object
    Severity: Major
    Found in packages/miew/src/ui/ObjectControls.js - About 6 hrs to fix

      Function mousedown has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
      Open

      ObjectControls.prototype.mousedown = function (event) {
  if (this.enabled === false || this._state !== STATE.NONE) {
    return
  }
      Severity: Minor
      Found in packages/miew/src/ui/ObjectControls.js - About 4 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function mousedown has 42 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      ObjectControls.prototype.mousedown = function (event) {
  if (this.enabled === false || this._state !== STATE.NONE) {
    return
  }
      Severity: Minor
      Found in packages/miew/src/ui/ObjectControls.js - About 1 hr to fix

        Function mouse2rotation has 37 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        ObjectHandler.prototype.mouse2rotation = (function () {
  const center = new Vector3()

  const eye = new Vector3()
  const eyeDirection = new Vector3()
        Severity: Minor
        Found in packages/miew/src/ui/ObjectControls.js - About 1 hr to fix

          Function update has 37 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          ObjectControls.prototype.update = (function () {
  const shift = new Vector2()

  return function () {
    const curTime = this._clock.getElapsedTime()
          Severity: Minor
          Found in packages/miew/src/ui/ObjectControls.js - About 1 hr to fix

            Function update has 34 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            ObjectHandler.prototype.update = (function () {
  const axis = new Vector3()

  return function (timeSinceLastUpdate, timeSinceMove) {
    if (settings.now.autoRotation !== 0.0) {
            Severity: Minor
            Found in packages/miew/src/ui/ObjectControls.js - About 1 hr to fix

              Function _rotate has 30 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              ObjectHandler.prototype._rotate = (function () {
  const p = new Vector3()
  const q = new Quaternion()
  const s = new Vector3()
              Severity: Minor
              Found in packages/miew/src/ui/ObjectControls.js - About 1 hr to fix

                Function touchstartend has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                ObjectControls.prototype.touchstartend = function (event) {
  if (this.enabled === false) {
    return
  }
                Severity: Minor
                Found in packages/miew/src/ui/ObjectControls.js - About 1 hr to fix

                  Function touchmove has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  ObjectControls.prototype.touchmove = function (event) {
  if (this.enabled === false || this._state === STATE.NONE) {
    return
  }
                  Severity: Minor
                  Found in packages/miew/src/ui/ObjectControls.js - About 1 hr to fix

                    Function mousemove has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                    ObjectControls.prototype.mousemove = function (event) {
  if (this.enabled === false || this._state === STATE.NONE) {
    return
  }
                    Severity: Minor
                    Found in packages/miew/src/ui/ObjectControls.js - About 1 hr to fix

                      Avoid deeply nested control flow statements.
                      Open

                                if ('axis' in altObj) {
            this._altObj.axis = altObj.axis.clone()
          } else {
            this._altObj.axis.set(0, 0, 1)
          }
                      Severity: Major
                      Found in packages/miew/src/ui/ObjectControls.js - About 45 mins to fix

                        Function ObjectControls has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                        function ObjectControls(object, objectPivot, camera, domElement, getAltObj) {
                        Severity: Minor
                        Found in packages/miew/src/ui/ObjectControls.js - About 35 mins to fix

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                          ObjectControls.prototype.handleResize = function () {
  if (this.domElement === document) {
    this.screen.left = 0
    this.screen.top = 0
    this.screen.width = window.innerWidth
                          Severity: Major
                          Found in packages/miew/src/ui/ObjectControls.js and 1 other location - About 1 day to fix
                          packages/miew/src/ui/Picker.js on lines 89..104

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 256.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                          ObjectControls.prototype.dispose = function () {
  for (let i = 0; i < this._listeners.length; i++) {
    const l = this._listeners[i]
    l.obj.removeEventListener(l.type, l.handler)
  }
                          Severity: Major
                          Found in packages/miew/src/ui/ObjectControls.js and 1 other location - About 2 hrs to fix
                          packages/miew/src/ui/Picker.js on lines 249..254

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 90.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                              case STATE.TRANSLATE:
      this._mousePrevPos.copy(this._mouseCurPos)
      this.convertMouseToViewport(this._mouseCurPos, event.pageX, event.pageY)
      this.translate()
      break
                          Severity: Major
                          Found in packages/miew/src/ui/ObjectControls.js and 1 other location - About 1 hr to fix
                          packages/miew/src/ui/ObjectControls.js on lines 743..747

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 63.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                              case STATE.TRANSLATE_PIVOT:
      this._mousePrevPos.copy(this._mouseCurPos)
      this.convertMouseToViewport(this._mouseCurPos, event.pageX, event.pageY)
      this.translatePivotByMouse()
      break
                          Severity: Major
                          Found in packages/miew/src/ui/ObjectControls.js and 1 other location - About 1 hr to fix
                          packages/miew/src/ui/ObjectControls.js on lines 737..741

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 63.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Identical blocks of code found in 2 locations. Consider refactoring.
                          Open

                                    if ('axis' in altObj) {
            this._altObj.axis = altObj.axis.clone()
          } else {
            this._altObj.axis.set(0, 0, 1)
          }
                          Severity: Major
                          Found in packages/miew/src/ui/ObjectControls.js and 1 other location - About 1 hr to fix
                          packages/miew/src/ui/ObjectControls.js on lines 640..644

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 62.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Identical blocks of code found in 2 locations. Consider refactoring.
                          Open

                                    if ('axis' in altObj) {
            this._altObj.axis = altObj.axis.clone()
          } else {
            this._altObj.axis.set(0, 0, 1)
          }
                          Severity: Major
                          Found in packages/miew/src/ui/ObjectControls.js and 1 other location - About 1 hr to fix
                          packages/miew/src/ui/ObjectControls.js on lines 686..690

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 62.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                            if (
    this._state === STATE.TRANSLATE ||
    this._state === STATE.TRANSLATE_PIVOT
  ) {
    this.convertMouseToViewport(this._mouseCurPos, event.pageX, event.pageY)
                          Severity: Minor
                          Found in packages/miew/src/ui/ObjectControls.js and 1 other location - About 40 mins to fix
                          packages/miew/src/ui/ObjectControls.js on lines 705..708

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 48.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                            if (this._state === STATE.ROTATE) {
    this.convertMouseToOnCircle(this._mouseCurPos, event.pageX, event.pageY)
    this._mousePrevPos.copy(this._mouseCurPos)
  }
                          Severity: Minor
                          Found in packages/miew/src/ui/ObjectControls.js and 1 other location - About 40 mins to fix
                          packages/miew/src/ui/ObjectControls.js on lines 710..716

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 48.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          There are no issues that match your filters.

                          Category
                          Status