Sign upLogin

epam/miew

View on GitHub
Star
packages/miew/src/ui/Picker.js

Summary

Maintainability
D
2 days
Test Coverage

Function Picker has 67 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function Picker(gfxObj, camera, domElement) {
  EventDispatcher.call(this)
  const self = this

  this.gfxObj = gfxObj
Severity: Major
Found in packages/miew/src/ui/Picker.js - About 2 hrs to fix

    Function pickObject has 45 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    Picker.prototype.pickObject = function (screenPos) {
  if (!this.gfxObj) {
    this.picked = {}
    this.dispatchEvent({ type: 'newpick', obj: {} })
    return
    Severity: Minor
    Found in packages/miew/src/ui/Picker.js - About 1 hr to fix

      Function pickObject has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

      Picker.prototype.pickObject = function (screenPos) {
  if (!this.gfxObj) {
    this.picked = {}
    this.dispatchEvent({ type: 'newpick', obj: {} })
    return
      Severity: Minor
      Found in packages/miew/src/ui/Picker.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function mouseup has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

      Picker.prototype.mouseup = function (event) {
  const self = this

  event.preventDefault()
  event.stopPropagation()
      Severity: Minor
      Found in packages/miew/src/ui/Picker.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      Picker.prototype.handleResize = function () {
  if (this.domElement === document) {
    this.screen.left = 0
    this.screen.top = 0
    this.screen.width = window.innerWidth
      Severity: Major
      Found in packages/miew/src/ui/Picker.js and 1 other location - About 1 day to fix
      packages/miew/src/ui/ObjectControls.js on lines 458..473

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 256.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      Picker.prototype.dispose = function () {
  for (let i = 0; i < this._listeners.length; i++) {
    const l = this._listeners[i]
    l.obj.removeEventListener(l.type, l.handler)
  }
      Severity: Major
      Found in packages/miew/src/ui/Picker.js and 1 other location - About 2 hrs to fix
      packages/miew/src/ui/ObjectControls.js on lines 898..903

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 90.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status