Sign upLogin

ericduran/chromeHAR

View on GitHub
Star
bower_components/angular-resource/angular-resource.js

Summary

Maintainability
C
1 day
Test Coverage

Function ResourceFactory has 100 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    function ResourceFactory(url, paramDefaults, actions) {
      var route = new Route(url);

      actions = extend({}, DEFAULT_ACTIONS, actions);
Severity: Major
Found in bower_components/angular-resource/angular-resource.js - About 4 hrs to fix

    Function name has 54 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            Resource[name] = function(a1, a2, a3, a4) {
          var params = {};
          var data;
          var success = noop;
          var error = null;
    Severity: Major
    Found in bower_components/angular-resource/angular-resource.js - About 2 hrs to fix

      Function url has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            url: function(params) {
        var self = this,
            url = this.template,
            val,
            encodedVal;
      Severity: Minor
      Found in bower_components/angular-resource/angular-resource.js - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            function encodeUriQuery(val, pctEncodeSpaces) {
      return encodeURIComponent(val).
        replace(/%40/gi, '@').
        replace(/%3A/gi, ':').
        replace(/%24/g, '$').
        Severity: Major
        Found in bower_components/angular-resource/angular-resource.js and 1 other location - About 1 hr to fix
        bower_components/angular/angular.js on lines 928..935

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 62.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            function encodeUriSegment(val) {
      return encodeUriQuery(val, true).
        replace(/%26/gi, '&').
        replace(/%3D/gi, '=').
        replace(/%2B/gi, '+');
        Severity: Minor
        Found in bower_components/angular-resource/angular-resource.js and 1 other location - About 40 mins to fix
        bower_components/angular/angular.js on lines 909..914

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 48.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status