erikroyall/hilo

View on GitHub
src/dom.js

Summary

Maintainability
F
1 wk
Test Coverage

Function class has a Cognitive Complexity of 137 (exceeds 5 allowed). Consider refactoring.
Open

    "class": feature.classList === true ? function (action, className) {
      return this.each(function (el) {
        var _i, parts, contains, res = [];

        if (typeof className === "string") { // A String
Severity: Minor
Found in src/dom.js - About 2 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File dom.js has 502 lines of code (exceeds 250 allowed). Consider refactoring.
Open


  //
  // ### Main DOM Class
  //
  // ** Params: **
Severity: Major
Found in src/dom.js - About 1 day to fix

    `` has 34 functions (exceeds 20 allowed). Consider refactoring.
    Open

      extend(Dom.prototype, {
    
        // ## Helper Functions
    
        // 
    Severity: Minor
    Found in src/dom.js - About 4 hrs to fix

      Function class has 105 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          "class": feature.classList === true ? function (action, className) {
            return this.each(function (el) {
              var _i, parts, contains, res = [];
      
              if (typeof className === "string") { // A String
      Severity: Major
      Found in src/dom.js - About 4 hrs to fix

        Function unitize has 43 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          function unitize (unit, prop) {
        
            /* All the CSS props. that are to be defaulted to px values */
            var pixel = {
              "width": true,
        Severity: Minor
        Found in src/dom.js - About 1 hr to fix

          Function create has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

            hilo.create = function (tagName, attrs) {
              var el = new Dom([document.createElement(tagName)]), key;
          
              if (attrs) {
                /* Add Class if the `className` is set */
          Severity: Minor
          Found in src/dom.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid deeply nested control flow statements.
          Open

                            if (contains) {
                              el.classList.remove(parts[_i]);
                            } else {
                              el.classList.add(parts[_i]);
                            }
          Severity: Major
          Found in src/dom.js - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                              if (contains(parts[_i])) {
                                el.classList.remove(parts[_i]);
                              } else {
                                el.classList.add(parts[_i]);
                              }
            Severity: Major
            Found in src/dom.js - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                              if (!contains(parts[_i])) {
                                el.className += " " +  parts[_i];
                              }
              Severity: Major
              Found in src/dom.js - About 45 mins to fix

                Avoid deeply nested control flow statements.
                Open

                                if (contains(parts[_i])) {
                                  el.classList.remove(parts[_i]);
                                } else {
                                  el.classList.add(parts[_i]);
                                }
                Severity: Major
                Found in src/dom.js - About 45 mins to fix

                  Avoid deeply nested control flow statements.
                  Open

                                    if (!contains(parts[_i])) {
                                      el.classList.add(parts[_i]);
                                    }
                  Severity: Major
                  Found in src/dom.js - About 45 mins to fix

                    Avoid deeply nested control flow statements.
                    Open

                                      if (contains(parts[_i])) {
                                        el.classList.remove(parts[_i]);
                                      }
                    Severity: Major
                    Found in src/dom.js - About 45 mins to fix

                      Avoid deeply nested control flow statements.
                      Open

                                        if (contains) {
                                          el.className.replace(className, "");
                                        } else {
                                          el.className += " " +  className;
                                        }
                      Severity: Major
                      Found in src/dom.js - About 45 mins to fix

                        Avoid deeply nested control flow statements.
                        Open

                                        if (contains(parts[_i])) {
                                          el.classList.remove(parts[_i]);
                                        }
                        Severity: Major
                        Found in src/dom.js - About 45 mins to fix

                          Avoid deeply nested control flow statements.
                          Open

                                            if (!contains(parts[_i])) {
                                              el.className += " " +  parts[_i];
                                            }
                          Severity: Major
                          Found in src/dom.js - About 45 mins to fix

                            Avoid deeply nested control flow statements.
                            Open

                                            if (contains(parts[_i])) {
                                              el.className.replace(parts[_i], "");
                                            }
                            Severity: Major
                            Found in src/dom.js - About 45 mins to fix

                              Avoid deeply nested control flow statements.
                              Open

                                              if (contains(parts[_i])) {
                                                el.className.replace(parts[_i], "");
                                              } else {
                                                el.className += " " +  parts[_i];
                                              }
                              Severity: Major
                              Found in src/dom.js - About 45 mins to fix

                                Avoid deeply nested control flow statements.
                                Open

                                                if (!contains(parts[_i])) {
                                                  el.classList.add(parts[_i]);
                                                }
                                Severity: Major
                                Found in src/dom.js - About 45 mins to fix

                                  Avoid deeply nested control flow statements.
                                  Open

                                                    if (contains(parts[_i])) {
                                                      el.className.replace(parts[_i], "");
                                                    }
                                  Severity: Major
                                  Found in src/dom.js - About 45 mins to fix

                                    Avoid deeply nested control flow statements.
                                    Open

                                                      if (contains(parts[_i])) {
                                                        el.className.replace(parts[_i], "");
                                                      } else {
                                                        el.className += " " +  parts[_i];
                                                      }
                                    Severity: Major
                                    Found in src/dom.js - About 45 mins to fix

                                      Function filter has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                                      Open

                                          filter: function (fn) {
                                            var len = this.length >>> 0
                                              , _i
                                              , t = Object(this)
                                              , res = []
                                      Severity: Minor
                                      Found in src/dom.js - About 25 mins to fix

                                      Cognitive Complexity

                                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                      A method's cognitive complexity is based on a few simple rules:

                                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                      • Code is considered more complex for each "break in the linear flow of the code"
                                      • Code is considered more complex when "flow breaking structures are nested"

                                      Further reading

                                      Identical blocks of code found in 3 locations. Consider refactoring.
                                      Open

                                        function unitize (unit, prop) {
                                      
                                          /* All the CSS props. that are to be defaulted to px values */
                                          var pixel = {
                                            "width": true,
                                      Severity: Major
                                      Found in src/dom.js and 2 other locations - About 1 day to fix
                                      build/hilo-legacy.js on lines 3858..3917
                                      build/hilo.js on lines 1828..1887

                                      Duplicated Code

                                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                      Tuning

                                      This issue has a mass of 274.

                                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                      Refactorings

                                      Further Reading

                                      Identical blocks of code found in 3 locations. Consider refactoring.
                                      Open

                                        hilo.create = function (tagName, attrs) {
                                          var el = new Dom([document.createElement(tagName)]), key;
                                      
                                          if (attrs) {
                                            /* Add Class if the `className` is set */
                                      Severity: Major
                                      Found in src/dom.js and 2 other locations - About 7 hrs to fix
                                      build/hilo-legacy.js on lines 3936..3961
                                      build/hilo.js on lines 1906..1931

                                      Duplicated Code

                                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                      Tuning

                                      This issue has a mass of 190.

                                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                      Refactorings

                                      Further Reading

                                      Identical blocks of code found in 3 locations. Consider refactoring.
                                      Open

                                        function Dom (els, sel) {
                                          var _i, _l;
                                      
                                          /* Note that `this` is an object and NOT an Array */
                                      
                                      
                                      Severity: Major
                                      Found in src/dom.js and 2 other locations - About 5 hrs to fix
                                      build/hilo-legacy.js on lines 3794..3809
                                      build/hilo.js on lines 1764..1779

                                      Duplicated Code

                                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                      Tuning

                                      This issue has a mass of 135.

                                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                      Refactorings

                                      Further Reading

                                      Identical blocks of code found in 3 locations. Consider refactoring.
                                      Open

                                        function unhyph (prop) {
                                          return prop.toLowerCase().replace(/-(.)/g, function (m, m1) {
                                            return m1.toUpperCase();
                                          });
                                        }
                                      Severity: Major
                                      Found in src/dom.js and 2 other locations - About 2 hrs to fix
                                      build/hilo-legacy.js on lines 3836..3840
                                      build/hilo.js on lines 1806..1810

                                      Duplicated Code

                                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                      Tuning

                                      This issue has a mass of 79.

                                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                      Refactorings

                                      Further Reading

                                      There are no issues that match your filters.

                                      Category
                                      Status