Sign upLogin

erikvw/django-collect-offline

View on GitHub
Star
django_collect_offline/static/django_offline/js/edc_sync.js

Summary

Maintainability
C
1 day
Test Coverage

Function processOutgoingTransactions has 62 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function processOutgoingTransactions( host, userName ) {
    /* 
    Process each OutgoingTransaction one at a time.
    Requests are chained: 
        1. GET outgoingtransaction from host;
Severity: Major
Found in django_collect_offline/static/django_offline/js/edc_sync.js - About 2 hrs to fix

    Function processIncomingTransactions has 49 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function processIncomingTransactions( homeUrl, userName ) {
    /*
    Process each IncomingTransaction one at a time.
    Requests are chained: 
        1. GET incoming from server;
    Severity: Minor
    Found in django_collect_offline/static/django_offline/js/edc_sync.js - About 1 hr to fix

      Function edcSyncReady has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function edcSyncReady(hosts, userName, apiToken, homeUrl) {
    /* Prepare page elements */
    var hosts = JSON.parse( hosts );
    var csrftoken = Cookies.get('csrftoken');
      Severity: Minor
      Found in django_collect_offline/static/django_offline/js/edc_sync.js - About 1 hr to fix

        Function makePageElements has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        function makePageElements ( divId, host, resourceName, listUrl, userName ) {
        Severity: Minor
        Found in django_collect_offline/static/django_offline/js/edc_sync.js - About 35 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              ajPostIncoming.fail( function( jqXHR, textStatus, errorThrown ) {
        console.log( textStatus + ': ' + errorThrown + '(on POST)' );
        $( '#id-resource-alert-text' ).text( 'Done. Host ' + host + '.');
    });
          Severity: Major
          Found in django_collect_offline/static/django_offline/js/edc_sync.js and 1 other location - About 1 hr to fix
          django_collect_offline/static/django_offline/js/edc_sync.js on lines 123..126

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 65.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              ajPatchOutgoing.fail(function( jqXHR, textStatus, errorThrown ) {
        console.log( textStatus + ': ' + errorThrown + '(on PATCH)');
        $( '#id-resource-alert-text' ).text( 'Done. Host ' + host + '.');
    });
          Severity: Major
          Found in django_collect_offline/static/django_offline/js/edc_sync.js and 1 other location - About 1 hr to fix
          django_collect_offline/static/django_offline/js/edc_sync.js on lines 118..121

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 65.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status