ernestwisniewski/kbin

View on GitHub

Showing 238 of 573 total issues

Similar blocks of code found in 11 locations. Consider refactoring.
Open

<?php

declare(strict_types=1);

namespace DoctrineMigrations;
Severity: Major
Found in migrations/Version20230429053840.php and 10 other locations - About 35 mins to fix
migrations/Version20220123173726.php on lines 1..34
migrations/Version20220404185534.php on lines 1..34
migrations/Version20220407171552.php on lines 1..34
migrations/Version20220621144628.php on lines 1..32
migrations/Version20220716142146.php on lines 1..34
migrations/Version20220924182955.php on lines 1..34
migrations/Version20221116150037.php on lines 1..32
migrations/Version20221222124812.php on lines 1..32
migrations/Version20230404080956.php on lines 1..34
migrations/Version20230429143017.php on lines 1..34

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 92.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function userIsOwner(User $user): bool
    {
        $user->moderatorTokens->get(-1);

        $criteria = Criteria::create()
Severity: Minor
Found in src/Entity/Magazine.php and 1 other location - About 35 mins to fix
src/Entity/Magazine.php on lines 174..183

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 92.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 11 locations. Consider refactoring.
Open

<?php

declare(strict_types=1);

namespace DoctrineMigrations;
Severity: Major
Found in migrations/Version20220404185534.php and 10 other locations - About 35 mins to fix
migrations/Version20220123173726.php on lines 1..34
migrations/Version20220407171552.php on lines 1..34
migrations/Version20220621144628.php on lines 1..32
migrations/Version20220716142146.php on lines 1..34
migrations/Version20220924182955.php on lines 1..34
migrations/Version20221116150037.php on lines 1..32
migrations/Version20221222124812.php on lines 1..32
migrations/Version20230404080956.php on lines 1..34
migrations/Version20230429053840.php on lines 1..34
migrations/Version20230429143017.php on lines 1..34

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 92.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 11 locations. Consider refactoring.
Open

<?php

declare(strict_types=1);

namespace DoctrineMigrations;
Severity: Major
Found in migrations/Version20220621144628.php and 10 other locations - About 35 mins to fix
migrations/Version20220123173726.php on lines 1..34
migrations/Version20220404185534.php on lines 1..34
migrations/Version20220407171552.php on lines 1..34
migrations/Version20220716142146.php on lines 1..34
migrations/Version20220924182955.php on lines 1..34
migrations/Version20221116150037.php on lines 1..32
migrations/Version20221222124812.php on lines 1..32
migrations/Version20230404080956.php on lines 1..34
migrations/Version20230429053840.php on lines 1..34
migrations/Version20230429143017.php on lines 1..34

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 92.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 11 locations. Consider refactoring.
Open

<?php

declare(strict_types=1);

namespace DoctrineMigrations;
Severity: Major
Found in migrations/Version20221116150037.php and 10 other locations - About 35 mins to fix
migrations/Version20220123173726.php on lines 1..34
migrations/Version20220404185534.php on lines 1..34
migrations/Version20220407171552.php on lines 1..34
migrations/Version20220621144628.php on lines 1..32
migrations/Version20220716142146.php on lines 1..34
migrations/Version20220924182955.php on lines 1..34
migrations/Version20221222124812.php on lines 1..32
migrations/Version20230404080956.php on lines 1..34
migrations/Version20230429053840.php on lines 1..34
migrations/Version20230429143017.php on lines 1..34

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 92.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    protected function serializeEntry(EntryDto|Entry $dto)
    {
        $response = $this->entryFactory->createResponseDto($dto);

        if ($this->isGranted('ROLE_OAUTH2_ENTRY:VOTE')) {
Severity: Minor
Found in src/Controller/Api/Entry/EntriesBaseApi.php and 1 other location - About 35 mins to fix
src/Controller/Api/Post/PostsBaseApi.php on lines 90..104

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 92.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function userIsModerator(User $user): bool
    {
        $user->moderatorTokens->get(-1);

        $criteria = Criteria::create()
Severity: Minor
Found in src/Entity/Magazine.php and 1 other location - About 35 mins to fix
src/Entity/Magazine.php on lines 185..194

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 92.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 11 locations. Consider refactoring.
Open

<?php

declare(strict_types=1);

namespace DoctrineMigrations;
Severity: Major
Found in migrations/Version20221222124812.php and 10 other locations - About 35 mins to fix
migrations/Version20220123173726.php on lines 1..34
migrations/Version20220404185534.php on lines 1..34
migrations/Version20220407171552.php on lines 1..34
migrations/Version20220621144628.php on lines 1..32
migrations/Version20220716142146.php on lines 1..34
migrations/Version20220924182955.php on lines 1..34
migrations/Version20221116150037.php on lines 1..32
migrations/Version20230404080956.php on lines 1..34
migrations/Version20230429053840.php on lines 1..34
migrations/Version20230429143017.php on lines 1..34

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 92.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 11 locations. Consider refactoring.
Open

<?php

declare(strict_types=1);

namespace DoctrineMigrations;
Severity: Major
Found in migrations/Version20220924182955.php and 10 other locations - About 35 mins to fix
migrations/Version20220123173726.php on lines 1..34
migrations/Version20220404185534.php on lines 1..34
migrations/Version20220407171552.php on lines 1..34
migrations/Version20220621144628.php on lines 1..32
migrations/Version20220716142146.php on lines 1..34
migrations/Version20221116150037.php on lines 1..32
migrations/Version20221222124812.php on lines 1..32
migrations/Version20230404080956.php on lines 1..34
migrations/Version20230429053840.php on lines 1..34
migrations/Version20230429143017.php on lines 1..34

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 92.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 11 locations. Consider refactoring.
Open

<?php

declare(strict_types=1);

namespace DoctrineMigrations;
Severity: Major
Found in migrations/Version20220123173726.php and 10 other locations - About 35 mins to fix
migrations/Version20220404185534.php on lines 1..34
migrations/Version20220407171552.php on lines 1..34
migrations/Version20220621144628.php on lines 1..32
migrations/Version20220716142146.php on lines 1..34
migrations/Version20220924182955.php on lines 1..34
migrations/Version20221116150037.php on lines 1..32
migrations/Version20221222124812.php on lines 1..32
migrations/Version20230404080956.php on lines 1..34
migrations/Version20230429053840.php on lines 1..34
migrations/Version20230429143017.php on lines 1..34

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 92.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 11 locations. Consider refactoring.
Open

<?php

declare(strict_types=1);

namespace DoctrineMigrations;
Severity: Major
Found in migrations/Version20230404080956.php and 10 other locations - About 35 mins to fix
migrations/Version20220123173726.php on lines 1..34
migrations/Version20220404185534.php on lines 1..34
migrations/Version20220407171552.php on lines 1..34
migrations/Version20220621144628.php on lines 1..32
migrations/Version20220716142146.php on lines 1..34
migrations/Version20220924182955.php on lines 1..34
migrations/Version20221116150037.php on lines 1..32
migrations/Version20221222124812.php on lines 1..32
migrations/Version20230429053840.php on lines 1..34
migrations/Version20230429143017.php on lines 1..34

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 92.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 11 locations. Consider refactoring.
Open

<?php

declare(strict_types=1);

namespace DoctrineMigrations;
Severity: Major
Found in migrations/Version20220716142146.php and 10 other locations - About 35 mins to fix
migrations/Version20220123173726.php on lines 1..34
migrations/Version20220404185534.php on lines 1..34
migrations/Version20220407171552.php on lines 1..34
migrations/Version20220621144628.php on lines 1..32
migrations/Version20220924182955.php on lines 1..34
migrations/Version20221116150037.php on lines 1..32
migrations/Version20221222124812.php on lines 1..32
migrations/Version20230404080956.php on lines 1..34
migrations/Version20230429053840.php on lines 1..34
migrations/Version20230429143017.php on lines 1..34

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 92.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 11 locations. Consider refactoring.
Open

<?php

declare(strict_types=1);

namespace DoctrineMigrations;
Severity: Major
Found in migrations/Version20220407171552.php and 10 other locations - About 35 mins to fix
migrations/Version20220123173726.php on lines 1..34
migrations/Version20220404185534.php on lines 1..34
migrations/Version20220621144628.php on lines 1..32
migrations/Version20220716142146.php on lines 1..34
migrations/Version20220924182955.php on lines 1..34
migrations/Version20221116150037.php on lines 1..32
migrations/Version20221222124812.php on lines 1..32
migrations/Version20230404080956.php on lines 1..34
migrations/Version20230429053840.php on lines 1..34
migrations/Version20230429143017.php on lines 1..34

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 92.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    protected function serializePostComment(PostCommentDto $comment): PostCommentResponseDto
    {
        $response = $this->postCommentFactory->createResponseDto($comment);

        if ($this->isGranted('ROLE_OAUTH2_POST_COMMENT:VOTE')) {
Severity: Minor
Found in src/Controller/Api/Post/PostsBaseApi.php and 1 other location - About 35 mins to fix
src/Controller/Api/Entry/EntriesBaseApi.php on lines 41..55

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 92.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

            const url = router().generate(`ajax_fetch_${getTypeFromNotification(data)}`, {id: data.detail.id});
Severity: Minor
Found in assets/controllers/subject_list_controller.js and 1 other location - About 35 mins to fix
assets/controllers/subject_list_controller.js on lines 22..22

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

            const url = router().generate(`ajax_fetch_${getTypeFromNotification(data)}`, {id: data.detail.id});
Severity: Minor
Found in assets/controllers/subject_list_controller.js and 1 other location - About 35 mins to fix
assets/controllers/subject_list_controller.js on lines 81..81

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            } else {
                $children = array_filter(
                    $comments,
                    fn ($val) => $val instanceof PostComment && $val->post === $parent
                );
Severity: Minor
Found in src/Kbin/SubjectOverviewListCreate.php and 1 other location - About 30 mins to fix
src/Kbin/SubjectOverviewListCreate.php on lines 33..51

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 90.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            if ($parent instanceof Entry) {
                $children = array_filter(
                    $comments,
                    fn ($val) => $val instanceof EntryComment && $val->entry === $parent
                );
Severity: Minor
Found in src/Kbin/SubjectOverviewListCreate.php and 1 other location - About 30 mins to fix
src/Kbin/SubjectOverviewListCreate.php on lines 42..51

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 90.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language