Showing 2 of 2 total issues
Method drink_list
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
Open
def drink_list(response)
count = response.match_data['c'] ? response.match_data['c'].to_i : 5
drinks = fetch_drinks
return response.reply(t('error.request')) unless drinks
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method keg_status_all
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
Open
def keg_status_all(response)
kegs = fetch_kegs
return response.reply(t('error.request')) unless kegs
return response.reply(t('kegs.none')) unless kegs.count > 0
kegs.each do |keg|
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"