Sign upLogin

espago/espago

View on GitHub
Star

Showing 3 of 5 total issues

Method calculate_checksum has 8 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def self.calculate_checksum(app_id, kind, session_id, amount, currency, ts, service_client_id, checksum_key)
Severity: Major
Found in lib/espago/secure_web_page.rb - About 1 hr to fix

    Method send_request has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def send_request(path, method, params = {})

      app_id = params[:app_id].present? ?  params.delete(:app_id) : @app_id
      app_password = params[:app_password].present? ? params.delete(:app_password) : @app_password
      production_param = !params[:production].nil? ? params.delete(:production) : production
    Severity: Minor
    Found in lib/espago/client.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method calculate_checksum has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def self.calculate_checksum(app_id, session_id, amount, currency, checksum_key)
    Severity: Minor
    Found in lib/espago/masterpass.rb - About 35 mins to fix
      Severity
      Category
      Status
      Source
      Language