Sign upLogin

ethereum/mist

View on GitHub
Star
interface/components/SendTx/FeeSelector.js

Summary

Maintainability
C
1 day
Test Coverage

Function parseFee has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  parseFee() {
    const {
      estimatedGas,
      gasPriceGweiStandard,
      gasPriceGweiPriority,
Severity: Minor
Found in interface/components/SendTx/FeeSelector.js - About 1 hr to fix

    Function renderStatus has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      renderStatus() {
    const { gasLoading } = this.props;
    const { gasRetries, ticks } = this.state;

    const spinner =
    Severity: Minor
    Found in interface/components/SendTx/FeeSelector.js - About 1 hr to fix

      Function parseFee has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

        parseFee() {
    const {
      estimatedGas,
      gasPriceGweiStandard,
      gasPriceGweiPriority,
      Severity: Minor
      Found in interface/components/SendTx/FeeSelector.js - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          if (network.toLowerCase() === 'main' && etherPriceUSD) {
      const standardFee = etherFee.times(etherPriceUSD);
      const formattedFee = this.formatter.format(standardFee);
      return `${formattedFee} USD (${etherFee} ETH)`;
    } else {
      Severity: Major
      Found in interface/components/SendTx/FeeSelector.js and 1 other location - About 2 hrs to fix
      interface/components/SendTx/FeeSelector.js on lines 64..70

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 88.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

            if (network.toLowerCase() === 'main' && etherPriceUSD) {
        const standardFee = etherFee.times(etherPriceUSD);
        const formattedFee = this.formatter.format(standardFee);
        return `${formattedFee} USD (${etherFee} ETH)`;
      } else {
      Severity: Major
      Found in interface/components/SendTx/FeeSelector.js and 1 other location - About 2 hrs to fix
      interface/components/SendTx/FeeSelector.js on lines 80..86

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 88.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                <span
            onClick={this.handleClick}
            className="fee-selector__btn"
            data-tooltip="Click For Priority Fee"
          >
      Severity: Minor
      Found in interface/components/SendTx/FeeSelector.js and 1 other location - About 45 mins to fix
      interface/components/SendTx/FeeSelector.js on lines 126..132

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 45.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                <span
            onClick={this.handleClick}
            className="fee-selector__btn"
            data-tooltip="Click For Standard Fee"
          >
      Severity: Minor
      Found in interface/components/SendTx/FeeSelector.js and 1 other location - About 45 mins to fix
      interface/components/SendTx/FeeSelector.js on lines 134..140

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 45.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Parsing error: 'import' and 'export' may appear only with 'sourceType: module'
      Open

      import React, { Component } from 'react';
      Severity: Minor
      Found in interface/components/SendTx/FeeSelector.js by eslint

      For more information visit Source: http://eslint.org/docs/rules/

      There are no issues that match your filters.

      Category
      Status