Sign upLogin

ethereum/mist

View on GitHub
Star
modules/clientBinaryManager.js

Summary

Maintainability
C
1 day
Test Coverage

Function _checkForNewConfig has 203 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  _checkForNewConfig(restart) {
    const nodeType = 'Geth';
    let binariesDownloaded = false;
    let nodeInfo;
Severity: Major
Found in modules/clientBinaryManager.js - About 1 day to fix

    File clientBinaryManager.js has 274 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    const _ = require('./utils/underscore.js');
const Q = require('bluebird');
const fs = require('fs');
const { app, dialog } = require('electron');
const got = require('got');
    Severity: Minor
    Found in modules/clientBinaryManager.js - About 2 hrs to fix

      Function _resolveEthBinPath has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        _resolveEthBinPath() {
    log.info('Resolving path to Eth client binary ...');

    let platform = process.platform;
      Severity: Minor
      Found in modules/clientBinaryManager.js - About 1 hr to fix

        'setInterval' is not defined.
        Open

            setInterval(() => this._checkForNewConfig(true), 1000 * 60 * 60);
        Severity: Minor
        Found in modules/clientBinaryManager.js by eslint

        Disallow Undeclared Variables (no-undef)

        This rule can help you locate potential ReferenceErrors resulting from misspellings of variable and parameter names, or accidental implicit globals (for example, from forgetting the var keyword in a for loop initializer).

        Rule Details

        Any reference to an undeclared variable causes a warning, unless the variable is explicitly mentioned in a /*global ...*/ comment, or specified in the globals key in the configuration file. A common use case for these is if you intentionally use globals that are defined elsewhere (e.g. in a script sourced from HTML).

        Examples of incorrect code for this rule:

        /*eslint no-undef: "error"*/

var a = someFunction();
b = 10;

        Examples of correct code for this rule with global declaration:

        /*global someFunction b:true*/
/*eslint no-undef: "error"*/

var a = someFunction();
b = 10;

        The b:true syntax in /*global */ indicates that assignment to b is correct.

        Examples of incorrect code for this rule with global declaration:

        /*global b*/
/*eslint no-undef: "error"*/

b = 10;

        By default, variables declared in /*global */ are read-only, therefore assignment is incorrect.

        Options

        • typeof set to true will warn for variables used inside typeof check (Default false).

        typeof

        Examples of correct code for the default { "typeof": false } option:

        /*eslint no-undef: "error"*/

if (typeof UndefinedIdentifier === "undefined") {
    // do something ...
}

        You can use this option if you want to prevent typeof check on a variable which has not been declared.

        Examples of incorrect code for the { "typeof": true } option:

        /*eslint no-undef: ["error", { "typeof": true }] */

if(typeof a === "string"){}

        Examples of correct code for the { "typeof": true } option with global declaration:

        /*global a*/
/*eslint no-undef: ["error", { "typeof": true }] */

if(typeof a === "string"){}

        Environments

        For convenience, ESLint provides shortcuts that pre-define global variables exposed by popular libraries and runtime environments. This rule supports these environments, as listed in [Specifying Environments](../user-guide/configuring.md#specifying-environments). A few examples are given below.

        browser

        Examples of correct code for this rule with browser environment:

        /*eslint no-undef: "error"*/
/*eslint-env browser*/

setTimeout(function() {
    alert("Hello");
});

        Node.js

        Examples of correct code for this rule with node environment:

        /*eslint no-undef: "error"*/
/*eslint-env node*/

var fs = require("fs");
module.exports = function() {
    console.log(fs);
};

        When Not To Use It

        If explicit declaration of global variables is not to your taste.

        Compatibility

        This rule provides compatibility with treatment of global variables in JSHint and JSLint. Source: http://eslint.org/docs/rules/

        There are no issues that match your filters.

        Category
        Status