Sign upLogin

ethereum/mist

View on GitHub
Star
modules/ipc/ipcProviderBackend.js

Summary

Maintainability
F
3 days
Test Coverage

File ipcProviderBackend.js has 469 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/**
The IPC provider backend filter and tunnel all incoming request to the ethereum node.

@module ipcProviderBackend
*/
Severity: Minor
Found in modules/ipc/ipcProviderBackend.js - About 7 hrs to fix

    Function _sendRequest has 100 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      _sendRequest(isSync, event, payload, retry = false) {
    const ownerId = event.sender.id;

    log.trace('sendRequest', isSync ? 'sync' : 'async', ownerId, payload);
    Severity: Major
    Found in modules/ipc/ipcProviderBackend.js - About 4 hrs to fix

      Function _getOrCreateConnection has 94 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        _getOrCreateConnection(event) {
    const owner = event.sender;
    const ownerId = owner.id;

    let socket;
      Severity: Major
      Found in modules/ipc/ipcProviderBackend.js - About 3 hrs to fix

        Function _handleSubscriptions has 38 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          _handleSubscriptions(result) {
    if (result.method === 'eth_subscribe') {
      // If subscription is created in local, also create the subscription in remote
      const subscriptionType = result.params[0];
      const subscriptionId = result.result;
        Severity: Minor
        Found in modules/ipc/ipcProviderBackend.js - About 1 hr to fix

          Function _subscribeRemote has 35 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            _subscribeRemote(localSubscriptionId, params, retry = false) {
    return new Promise(async (resolve, reject) => {
      log.trace(
        `Creating remote subscription: ${params} (local subscription id: ${localSubscriptionId})`
      );
          Severity: Minor
          Found in modules/ipc/ipcProviderBackend.js - About 1 hr to fix

            Function _makeResponsePayload has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

              _makeResponsePayload(originalPayload, value) {
    const finalValue = _.isArray(originalPayload) ? value : [value];

    const allResults = [].concat(originalPayload).map((item, idx) => {
      const finalResult = finalValue[idx];
            Severity: Minor
            Found in modules/ipc/ipcProviderBackend.js - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function _handleSubscriptions has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

              _handleSubscriptions(result) {
    if (result.method === 'eth_subscribe') {
      // If subscription is created in local, also create the subscription in remote
      const subscriptionType = result.params[0];
      const subscriptionId = result.result;
            Severity: Minor
            Found in modules/ipc/ipcProviderBackend.js - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function _onNodeStateChanged has 27 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              _onNodeStateChanged(state) {
    switch (
      state // eslint-disable-line default-case
    ) {
      // stop syncing when node about to be stopped
            Severity: Minor
            Found in modules/ipc/ipcProviderBackend.js - About 1 hr to fix

              Function _sendRemoteResult has 27 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                _sendRemoteResult(localSubscriptionId, remoteResult) {
    if (store.getState().nodes.active === 'remote') {
      // Set up object to send
      const res = {
        jsonrpc: '2.0',
              Severity: Minor
              Found in modules/ipc/ipcProviderBackend.js - About 1 hr to fix

                Function _sendRemoteResult has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Open

                  _sendRemoteResult(localSubscriptionId, remoteResult) {
    if (store.getState().nodes.active === 'remote') {
      // Set up object to send
      const res = {
        jsonrpc: '2.0',
                Severity: Minor
                Found in modules/ipc/ipcProviderBackend.js - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function _makeErrorResponsePayload has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                  _makeErrorResponsePayload(originalPayload, error) {
    const e = [].concat(originalPayload).map(item => {
      const e = _.extend(
        {
          jsonrpc: '2.0'
                Severity: Minor
                Found in modules/ipc/ipcProviderBackend.js - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                          const processor = this._processors[p.method]
            ? this._processors[p.method]
            : this._processors.base;
                Severity: Major
                Found in modules/ipc/ipcProviderBackend.js and 2 other locations - About 40 mins to fix
                modules/ipc/ipcProviderBackend.js on lines 345..347
                modules/ipc/ipcProviderBackend.js on lines 368..370

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 44.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                              const processor = this._processors[p.method]
                ? this._processors[p.method]
                : this._processors.base;
                Severity: Major
                Found in modules/ipc/ipcProviderBackend.js and 2 other locations - About 40 mins to fix
                modules/ipc/ipcProviderBackend.js on lines 325..327
                modules/ipc/ipcProviderBackend.js on lines 345..347

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 44.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                            const processor = this._processors[finalPayload.method]
              ? this._processors[finalPayload.method]
              : this._processors.base;
                Severity: Major
                Found in modules/ipc/ipcProviderBackend.js and 2 other locations - About 40 mins to fix
                modules/ipc/ipcProviderBackend.js on lines 325..327
                modules/ipc/ipcProviderBackend.js on lines 368..370

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 44.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        try {
          data = JSON.parse(data);
        } catch (error) {
          log.trace('Error parsing data: ', data);
        }
                Severity: Minor
                Found in modules/ipc/ipcProviderBackend.js and 1 other location - About 35 mins to fix
                modules/ethereumNodeRemote.js on lines 240..244

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 41.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Parsing error: Unexpected token =>
                Open

                    return new Promise(async (resolve, reject) => {
                Severity: Minor
                Found in modules/ipc/ipcProviderBackend.js by eslint

                For more information visit Source: http://eslint.org/docs/rules/

                There are no issues that match your filters.

                Category
                Status