Sign upLogin

etsy/411

View on GitHub
Star
htdocs/assets/js/view.js

Summary

Maintainability
B
6 hrs
Test Coverage

File view.js has 261 lines of code (exceeds 250 allowed). Consider refactoring.
Open

"use strict";
define(function(require) {
    var $ = require('jquery'),
        _ = require('underscore'),
        Backbone = require('backbone'),
Severity: Minor
Found in htdocs/assets/js/view.js - About 2 hrs to fix

    Function destroyElement has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            destroyElement: function(k) {
            var elems = this.childElements[k];
            if(_.isUndefined(elems)) {
                throw 'Called destroyChild on unknown key: ' + k;
            }
    Severity: Minor
    Found in htdocs/assets/js/view.js - About 1 hr to fix

      Function registerView has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              registerView: function(view, init, sel, str) {
            if(_.isUndefined(str)) str = view.cid;
            if(_.isUndefined(sel)) sel = this.$el;
            var arr = str.substr(-2) === '[]';
            if(this.childViewNamesToIDs[str] && !arr) {
      Severity: Minor
      Found in htdocs/assets/js/view.js - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                cbRendered: function(cb) {
            return $.proxy(function() {
                if(this.rendered()) { cb.apply(this, arguments); }
            }, this);
        },
        Severity: Major
        Found in htdocs/assets/js/view.js and 1 other location - About 1 hr to fix
        htdocs/assets/js/view.js on lines 409..413

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 56.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                cbLoaded: function(cb) {
            return $.proxy(function() {
                if(this.loaded()) { cb.apply(this, arguments); }
            }, this);
        },
        Severity: Major
        Found in htdocs/assets/js/view.js and 1 other location - About 1 hr to fix
        htdocs/assets/js/view.js on lines 400..404

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 56.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status