Sign upLogin

etsy/morgue

View on GitHub
Star

Showing 42 of 1,422 total issues

Function calendarLinkHandler has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

function calendarLinkHandler()
{
    if (cal.authorized) {
        if(cal.event === null || cal.event.status == 'cancelled') {
            createEvent();
Severity: Minor
Found in features/calendar/assets/js/calendar.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function update_gcal_for_event has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

function update_gcal_for_event() {
  var url = "/events/" + get_current_event_id();
  var gcal = $("#gcal").val();
  // some basic client side validation
Severity: Minor
Found in htdocs/assets/js/api.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language