eventmachine/eventmachine

View on GitHub

Showing 131 of 147 total issues

Avoid deeply nested control flow statements.
Open

    elsif opcode == ConnectionData
      c = @conns[conn_binding] or raise ConnectionNotBound, "received data #{data} for unknown signature: #{conn_binding}"
      c.receive_data data
    elsif opcode == LoopbreakSignalled
      run_deferred_callbacks
Severity: Major
Found in lib/eventmachine.rb - About 45 mins to fix

    Method dispatchInboundData has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        public ByteBuffer dispatchInboundData (ByteBuffer bb) throws SSLException {
            if (sslEngine != null) {
                if (true) throw new RuntimeException ("TLS currently unimplemented");
                System.setProperty("javax.net.debug", "all");
                ByteBuffer w = ByteBuffer.allocate(32*1024); // TODO, WRONG, preallocate this buffer.
    Severity: Minor
    Found in java/src/com/rubyeventmachine/EventableSocketChannel.java - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method start_server has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

      def self.start_server server, port=nil, handler=nil, *args, &block
        begin
          port = Integer(port)
        rescue ArgumentError, TypeError
          # there was no port, so server must be a unix domain socket
    Severity: Minor
    Found in lib/eventmachine.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method close has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        public void close() {
            if (channelKey != null) {
                channelKey.cancel();
                channelKey = null;
            }
    Severity: Minor
    Found in java/src/com/rubyeventmachine/EventableSocketChannel.java - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method scheduleOutboundData has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        public void scheduleOutboundData (ByteBuffer bb) {
            if (!bCloseScheduled && bb.remaining() > 0) {
                if (sslEngine != null) {
                    try {
                        ByteBuffer b = ByteBuffer.allocate(32*1024); // TODO, preallocate this buffer.
    Severity: Minor
    Found in java/src/com/rubyeventmachine/EventableSocketChannel.java - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid deeply nested control flow statements.
    Open

      add_define 'WITH_SSL' if find_openssl_library
    Severity: Major
    Found in ext/extconf.rb - About 45 mins to fix

      Method invoke_auth has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

            def invoke_auth
              if @args[:auth]
                if @args[:auth][:type] == :plain
                  psw = @args[:auth][:password]
                  if psw.respond_to?(:call)
      Severity: Minor
      Found in lib/em/protocols/smtpclient.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid deeply nested control flow statements.
      Open

                      if (@content_length and @content_length > 0) || @chunked || @connection_close
                        @read_state = :content
                      else
                        dispatch_response
                        @read_state = :base
      Severity: Major
      Found in lib/em/protocols/httpclient.rb - About 45 mins to fix

        Method isReadable has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            void isReadable (SelectionKey k) {
                EventableChannel ec = (EventableChannel) k.attachment();
                long b = ec.getBinding();
        
                if (ec.isWatchOnly()) {
        Severity: Minor
        Found in java/src/com/rubyeventmachine/EmReactor.java - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method isWritable has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            void isWritable (SelectionKey k) {
                EventableChannel ec = (EventableChannel) k.attachment();
                long b = ec.getBinding();
        
                if (ec.isWatchOnly()) {
        Severity: Minor
        Found in java/src/com/rubyeventmachine/EmReactor.java - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid deeply nested control flow statements.
        Open

                      if @lt2_textpos >= @lt2_textsize
                        # Reset line mode (the default behavior) BEFORE calling the
                        # receive_binary_data. This makes it possible for user code
                        # to call set_text_mode, enabling chains of text blocks
                        # (which can possibly be of different sizes).
        Severity: Major
        Found in lib/em/protocols/linetext2.rb - About 45 mins to fix

          Method bind_connect has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

            def self.bind_connect bind_addr, bind_port, server, port=nil, handler=nil, *args
          Severity: Minor
          Found in lib/eventmachine.rb - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                        elsif @content_length
                          # If there was no content-length header, we have to wait until the connection
                          # closes. Everything we get until that point is content.
                          # TODO: Must impose a content-size limit, and also must implement chunking.
                          # Also, must support either temporary files for large content, or calling
            Severity: Major
            Found in lib/em/protocols/httpclient.rb - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                            will_take = if remaining_data.length > needed
                                          needed
                                        else
                                          remaining_data.length
                                        end
              Severity: Major
              Found in lib/em/protocols/linetext2.rb - About 45 mins to fix

                Method run_deferred_callbacks has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Open

                  def self.run_deferred_callbacks
                    until (@resultqueue ||= []).empty?
                      result,cback = @resultqueue.pop
                      cback.call result if cback
                    end
                Severity: Minor
                Found in lib/eventmachine.rb - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Avoid deeply nested control flow statements.
                Open

                            rescue Exception => error
                              @wrapped_exception = error
                              stop
                Severity: Major
                Found in lib/eventmachine.rb - About 45 mins to fix

                  Method receive_line has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                  Open

                        def receive_line line
                          @stomp_initialized || init_message_reader
                          @stomp_message.consume_line(line) {|outcome|
                            if outcome.first == :sized_text
                              set_text_mode outcome[1]
                  Severity: Minor
                  Found in lib/em/protocols/stomp.rb - About 45 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method send_cmd has 6 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                        def send_cmd cmd, key, flags = 0, exptime = 0, bytes = 0, noreply = false
                  Severity: Minor
                  Found in lib/em/protocols/memcache.rb - About 45 mins to fix

                    Method receive_chunk_header has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                    Open

                            def receive_chunk_header ln
                              if ln.length > 0
                                chunksize = ln.to_i(16)
                                if chunksize > 0
                                  @conn.set_text_mode(ln.to_i(16))
                    Severity: Minor
                    Found in lib/em/protocols/httpclient2.rb - About 45 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Avoid deeply nested control flow statements.
                    Open

                                    if @headers.length == 1
                                      parse_response_line
                                    elsif ary.first =~ /\Acontent-length:\s*/i
                                      # Only take the FIRST content-length header that appears,
                                      # which we can distinguish because @content_length is nil.
                    Severity: Major
                    Found in lib/em/protocols/httpclient.rb - About 45 mins to fix
                      Severity
                      Category
                      Status
                      Source
                      Language