Sign upLogin

eveseat/eveapi

View on GitHub
Star

Showing 103 of 440 total issues

Avoid too many return statements within this method.
Open

        return $this->moon_indicators ?: (object) [
            'ubiquitous' => 0,
            'common' => 0,
            'uncommon' => 0,
            'rare' => 0,
Severity: Major
Found in src/Models/Sde/MapDenormalize.php - About 30 mins to fix

    Function handle has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        public function handle()
    {
        parent::handle();

        // it looks like we've loaded it in the meantime
    Severity: Minor
    Found in src/Jobs/Universe/Structures/Citadel.php - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function importMysqlSde has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        private function importMysqlSde()
    {
        $bar = $this->getProgressBar(count($this->json->tables));

        foreach ($this->json->tables as $table) {
    Severity: Minor
    Found in src/Commands/Eve/Update/Sde.php - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language