Sign upLogin

eveseat/notifications

View on GitHub
Star

Showing 25 of 405 total issues

Method toSlack has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function toSlack($notifiable)
    {
        return (new SlackMessage)
            ->content('A sovereignty structure has been reinforced!')
            ->from('SeAT Sovereignty Health')
Severity: Minor
Found in src/Notifications/Sovereignties/Slack/SovStructureReinforced.php - About 1 hr to fix

    Method toSlack has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function toSlack($notifiable)
    {
        return (new SlackMessage)
            ->from('SeAT War Observer')
            ->content('A war has been invalidated!')
    Severity: Minor
    Found in src/Notifications/Wars/Slack/AllWarInvalidatedMsg.php - About 1 hr to fix

      Method toSlack has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function toSlack($notifiable)
    {

        $message = (new SlackMessage)
            ->content('A kill has been recorded for your corporation!')
      Severity: Minor
      Found in src/Notifications/Characters/Slack/Killmail.php - About 1 hr to fix

        Method toSlack has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function toSlack($notifiable)
    {
        return (new SlackMessage)
            ->from('SeAT Alliance Weather')
            ->content('Capital has been modified!')
        Severity: Minor
        Found in src/Notifications/Alliances/Slack/AllianceCapitalChanged.php - About 1 hr to fix

          Function toMail has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              public function toMail($notifiable)
    {
        $mail = (new MailMessage)
            ->subject('Character Left Corp Notification!')
            ->line('A character has left the corporation!');
          Severity: Minor
          Found in src/Notifications/Corporations/Mail/CharLeftCorpMsg.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language