Showing 186 of 479 total issues

Method apply has 54 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function apply($query)
    {
        // extract querying table (from)
        $table = $query->getQuery()->from;

Severity: Major
Found in src/Http/DataTables/Scopes/CharacterScope.php - About 2 hrs to fix

    Method ajax has 54 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function ajax()
        {
            return datatables()
                ->eloquent($this->applyScopes($this->query()))
                ->editColumn('refresh_token.expires_on', function ($row) {
    Severity: Major
    Found in src/Http/DataTables/Corporation/Intel/MembersTrackingDataTable.php - About 2 hrs to fix

      Method getSearchMailData has 54 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function getSearchMailData(Request $request)
          {
      
              $mail = $this->doSearchCharacterMail();
      
      
      Severity: Major
      Found in src/Http/Controllers/Support/SearchController.php - About 2 hrs to fix

        Method ajax has 53 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function ajax()
            {
                return datatables()
                    ->eloquent($this->applyScopes($this->query()))
                    ->editColumn('date', function ($row) {

          Method getTransactionContent has 53 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function getTransactionContent(CharacterInfo $character, int $client_id)
              {
          
                  $character_ids = collect($character->character_id);
          
          
          Severity: Major
          Found in src/Http/Controllers/Character/IntelController.php - About 2 hrs to fix

            Method apply has 51 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function apply($query)
                {
                    if ($this->requested_characters != null) {
                        $character_ids = collect($this->requested_characters)->filter(function ($item) {
                            return Gate::allows('character.intel', [$item]);
            Severity: Major
            Found in src/Http/DataTables/Scopes/CharacterNoteScope.php - About 2 hrs to fix

              Method apply has 51 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function apply($query)
                  {
                      if ($this->requested_characters != null) {
                          $character_ids = collect($this->requested_characters)->filter(function ($item) {
                              return Gate::allows('character.killmail', [$item]);
              Severity: Major
              Found in src/Http/DataTables/Scopes/KillMailCharacterScope.php - About 2 hrs to fix

                Method getCharacterSkillCoverage has 51 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function getCharacterSkillCoverage(int $character_id): Collection
                    {
                
                        $in_game_skills = DB::table('invTypes')
                            ->join(
                Severity: Major
                Found in src/Traits/Stats.php - About 2 hrs to fix

                  Method ajax has 50 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function ajax()
                      {
                          $location_column = $this->getLocationFlagColumn($this);
                          $station_column = $this->getStationColumn($this);
                  
                  
                  Severity: Minor
                  Found in src/Http/DataTables/Common/Intel/AbstractAssetDataTable.php - About 2 hrs to fix

                    Method ajax has 48 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public function ajax()
                        {
                            return datatables()
                                ->eloquent($this->applyScopes($this->query()))
                                ->editColumn('planet.name', function ($row) {

                      Method ajax has 48 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          public function ajax()
                          {
                              return datatables()
                                  ->eloquent($this->applyScopes($this->query()))
                                  ->editColumn('date', function ($row) {

                        Method ajax has 48 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            public function ajax()
                            {
                        
                                return datatables()
                                    ->eloquent($this->applyScopes($this->query()))
                        Severity: Minor
                        Found in src/Http/DataTables/Common/Intel/AbstractContactDataTable.php - About 1 hr to fix

                          Method ajax has 48 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              public function ajax()
                              {
                                  return datatables()->eloquent($this->query())
                                      ->editColumn('users.name', function ($row) {
                                          $main_character = new CharacterInfo([
                          Severity: Minor
                          Found in src/Http/DataTables/Configuration/UsersDataTable.php - About 1 hr to fix

                            Function register_policies has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
                            Open

                                private function register_policies()
                                {
                                    $permissions = config('seat.permissions', []);
                            
                                    Gate::define('global.superuser', 'Seat\Web\Acl\Policies\GlobalPolicy@superuser');
                            Severity: Minor
                            Found in src/WebServiceProvider.php - About 1 hr to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Method resolveIdsToNames has 47 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                public function resolveIdsToNames(Request $request)
                                {
                            
                                    // Resolve the Esi client library from the IoC
                                    $eseye = app('esi-client')->get();
                            Severity: Minor
                            Found in src/Http/Controllers/Support/ResolveController.php - About 1 hr to fix

                              Method getJournalContent has 47 lines of code (exceeds 25 allowed). Consider refactoring.
                              Open

                                  public function getJournalContent(CharacterInfo $character, int $first_party_id, int $second_party_id, string $ref_type)
                                  {
                              
                                      $character_ids = collect($character->character_id);
                              
                              
                              Severity: Minor
                              Found in src/Http/Controllers/Character/IntelController.php - About 1 hr to fix

                                Method ajax has 46 lines of code (exceeds 25 allowed). Consider refactoring.
                                Open

                                    public function ajax()
                                    {
                                        return datatables()
                                            ->eloquent($this->applyScopes($this->query()))
                                            ->addColumn('is_candidate', function ($row) {
                                Severity: Minor
                                Found in src/Http/DataTables/Squads/SquadsDataTable.php - About 1 hr to fix

                                  Method ajax has 45 lines of code (exceeds 25 allowed). Consider refactoring.
                                  Open

                                      public function ajax()
                                      {
                                          return datatables()
                                              ->eloquent($this->applyScopes($this->query()))
                                              ->editColumn('moon.region.name', function ($row) {
                                  Severity: Minor
                                  Found in src/Http/DataTables/Tools/MoonsDataTable.php - About 1 hr to fix

                                    Method getTopWalletJournalData has 44 lines of code (exceeds 25 allowed). Consider refactoring.
                                    Open

                                        public function getTopWalletJournalData(CharacterInfo $character)
                                        {
                                    
                                            if (! request()->has('characters'))
                                                return abort(500);
                                    Severity: Minor
                                    Found in src/Http/Controllers/Character/IntelController.php - About 1 hr to fix

                                      Method getStandingsAjaxElementName has 44 lines of code (exceeds 25 allowed). Consider refactoring.
                                      Open

                                          public function getStandingsAjaxElementName(Request $request)
                                          {
                                      
                                              $response = [
                                                  'results' => [],
                                      Severity: Minor
                                      Found in src/Http/Controllers/Tools/StandingsController.php - About 1 hr to fix
                                        Severity
                                        Category
                                        Status
                                        Source
                                        Language