Sign upLogin

evg-c/java-project-71

View on GitHub
Star

Showing 5 of 5 total issues

Method diffOneKey has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

    public static Map<String, Object> diffOneKey(String keyMap, Map<String, Object> map1, Map<String, Object> map2) {
        String statusElement = "unchanged";
        Object oldValue = null;
        Object newValue = null;
        if (map1.keySet().contains(keyMap) && (!map2.keySet().contains(keyMap))) {
Severity: Minor
Found in app/src/main/java/hexlet/code/CreateDataMap.java - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

        return true;
Severity: Major
Found in app/src/main/java/hexlet/code/Differ.java - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

            return true;
    Severity: Major
    Found in app/src/main/java/hexlet/code/Differ.java - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                  return false;
      Severity: Major
      Found in app/src/main/java/hexlet/code/Differ.java - About 30 mins to fix

        Method checkingParameters has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            public static boolean checkingParameters(String file1, String file2, String format) throws IOException {
        if (!checkParameterFile(file1) || (!checkParameterFile(file2))) {
            return false;
        }
        if (file1.equals(file2)) {
        Severity: Minor
        Found in app/src/main/java/hexlet/code/Differ.java - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language