Showing 13 of 26 total issues
Function addCalculatedValues
has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring. Open
private addCalculatedValues(locationData: InternalLocationData): LocationData {
const calculatedValues = locationData.values.map((valuesOnDate, index) => {
let newConfirmed = 0;
let newRecovered: number | null = null;
let newDeaths: number | null = null;
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
File COVID19API.ts
has 298 lines of code (exceeds 250 allowed). Consider refactoring. Open
import { COVID19APIError } from "./COVID19APIError";
import { DataGetter } from "./DataGetter/DataGetter";
import { FileGetter } from "./DataGetter/FileGetter";
import { GitHubGetter } from "./DataGetter/GitHubGetter";
import { DataStore, DataStoreInvalidLocationError } from "./DataStore/DataStore";
COVID19API
has 24 functions (exceeds 20 allowed). Consider refactoring. Open
export class COVID19API {
private readonly dataValidityInMS: number;
private readonly lazyLoadUSData: boolean;
private readonly onLoadingStatusChange:
| ((isLoading: boolean, loadingMessage?: string) => void)
Function putLocationData
has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring. Open
async putLocationData(data: InternalLocationData[]): Promise<void> {
if (this.data == null || this.counties == null || this.states == null) {
throw new DataStoreNotInitializedError();
}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function addCalculatedValues
has 41 lines of code (exceeds 25 allowed). Consider refactoring. Open
private addCalculatedValues(locationData: InternalLocationData): LocationData {
const calculatedValues = locationData.values.map((valuesOnDate, index) => {
let newConfirmed = 0;
let newRecovered: number | null = null;
let newDeaths: number | null = null;
Function calculatedValues
has 35 lines of code (exceeds 25 allowed). Consider refactoring. Open
const calculatedValues = locationData.values.map((valuesOnDate, index) => {
let newConfirmed = 0;
let newRecovered: number | null = null;
let newDeaths: number | null = null;
let recoveryRate: number | null = 0;
Function formatParsedData
has 35 lines of code (exceeds 25 allowed). Consider refactoring. Open
function formatParsedData(
parsedConfirmedData: ParsedCSV,
parsedDeathsData: ParsedCSV,
parsedRecoveredData?: ParsedCSV
): InternalLocationData[] {
Function constructor
has 34 lines of code (exceeds 25 allowed). Consider refactoring. Open
constructor(options: COVID19APIOptions = {}) {
const { lazyLoadUSData, dataValidityInMS, onLoadingStatusChange, fetch } = options;
this.lazyLoadUSData = lazyLoadUSData ?? true;
this.dataValidityInMS = dataValidityInMS ?? 60 * 60 * 1000; // 1 hour
Function loadDataIfStoreHasNoFreshData
has 30 lines of code (exceeds 25 allowed). Consider refactoring. Open
private async loadDataIfStoreHasNoFreshData(forceLoadUSData = false): Promise<void> {
const hasFreshData = await this.hasFreshDataInStore();
const hasUSData = await this.hasUSDataInStore();
let sourceLastUpdatedAt: Date | undefined;
Function loadDataIfStoreHasNoFreshData
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
private async loadDataIfStoreHasNoFreshData(forceLoadUSData = false): Promise<void> {
const hasFreshData = await this.hasFreshDataInStore();
const hasUSData = await this.hasUSDataInStore();
let sourceLastUpdatedAt: Date | undefined;
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function sumMultipleLocationValues
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
function sumMultipleLocationValues(data: InternalLocationData[]): InternalLocationDataValues {
let sum: InternalLocationDataValues = [];
data.forEach(({ values }, index) => {
if (index === 0) {
Function formatGlobalParsedData
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
export function formatGlobalParsedData(
parsedGlobalConfirmedData: ParsedCSV,
parsedGlobalDeathsData: ParsedCSV,
parsedGlobalRecoveredData: ParsedCSV
): InternalLocationData[] {
Function formatParsedData
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
function formatParsedData(
parsedConfirmedData: ParsedCSV,
parsedDeathsData: ParsedCSV,
parsedRecoveredData?: ParsedCSV
): InternalLocationData[] {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"