Sign upLogin

exadel-inc/esl

View on GitHub
Star

Comparing main to feat/prettier

Last commit f17527e6 about 2 years ago
Compare on GitHub

Showing 3 of 3 total issues

Function fitOnMinorAxis has 37 lines of code (exceeds 25 allowed). Consider refactoring.
New

function fitOnMinorAxis(cfg: PopupPositionConfig, rect: Rect, arrow: Point): void {
  if (cfg.behavior !== 'fit' && cfg.behavior !== 'fit-on-minor') return;
 
  const isHorizontal = isMajorAxisHorizontal(cfg.position);
  const start = isHorizontal ? 'y' : 'x';
Severity: Minor
Found in src/modules/esl-popup/core/esl-popup-position.ts - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Fixed

    Severity: Minor
    Found in src/modules/esl-mixin-element/ui/esl-mixin-registry.ts and 1 other location - About 55 mins to fix
    src/modules/esl-mixin-element/ui/esl-mixin-registry.ts on lines 107..109

    Similar blocks of code found in 2 locations. Consider refactoring.
    Fixed

    Severity: Minor
    Found in src/modules/esl-mixin-element/ui/esl-mixin-registry.ts and 1 other location - About 55 mins to fix
    src/modules/esl-mixin-element/ui/esl-mixin-registry.ts on lines 104..106
    Category
    Status
    FileMaintainabilityTest Coverage
    src/modules/esl-popup/core/esl-popup-position.ts
    C
    D
    +1 hr