Sign upLogin

expressly/expressly-plugin-sdk-ruby-core

View on GitHub
Star

Showing 4 of 25 total issues

File domain.rb has 407 lines of code (exceeds 250 allowed). Consider refactoring.
Open

module Expressly
  class CustomerImport
    attr_accessor :metadata, :primary_email, :customer, :cart
    def initialize(attribute_value_map = {})
      attribute_value_map.map { |(k, v)| public_send("#{k}=", v) }
Severity: Minor
Found in lib/expressly/domain.rb - About 5 hrs to fix

    Method execute has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def execute(method_uri, http_verb, body = nil, limit = 4)
      raise 'too many HTTP redirects' if limit == 0

      uri = URI.parse("#{@endpoint}#{method_uri}")
      http = Net::HTTP.new(uri.host, uri.port)
    Severity: Minor
    Found in lib/expressly/api.rb - About 1 hr to fix

      Method execute has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          def execute(method_uri, http_verb, body = nil, limit = 4)
      raise 'too many HTTP redirects' if limit == 0

      uri = URI.parse("#{@endpoint}#{method_uri}")
      http = Net::HTTP.new(uri.host, uri.port)
      Severity: Minor
      Found in lib/expressly/api.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def initialize(api_key, merchant_plugin_provider, merchant_plugin_endpoint, merchant_metadata = {}, expressly_endpoint = 'https://prod.expresslyapp.com/api')
      Severity: Minor
      Found in lib/expressly.rb - About 35 mins to fix
        Severity
        Category
        Status
        Source
        Language