Sign upLogin

exsilium/xmodem

View on GitHub
Star

Showing 5 of 5 total issues

Method receive has a Cognitive Complexity of 51 (exceeds 5 allowed). Consider refactoring.
Open

  def XMODEM::receive(remote,local,options=nil)

    mode = ( (options.nil?) || options[:mode].nil? ) ? :checksum : options[:mode]

    logger.debug "receiver: XMODEM - #{mode}"
Severity: Minor
Found in lib/xmodem.rb - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method send has a Cognitive Complexity of 35 (exceeds 5 allowed). Consider refactoring.
Open

  def XMODEM::send(remote,local)
    block_number=1
    current_block=""
    sent_eot=false
Severity: Minor
Found in lib/xmodem.rb - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method receive has 92 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def XMODEM::receive(remote,local,options=nil)

    mode = ( (options.nil?) || options[:mode].nil? ) ? :checksum : options[:mode]

    logger.debug "receiver: XMODEM - #{mode}"
Severity: Major
Found in lib/xmodem.rb - About 3 hrs to fix

    Method send has 64 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def XMODEM::send(remote,local)
    block_number=1
    current_block=""
    sent_eot=false
    Severity: Major
    Found in lib/xmodem.rb - About 2 hrs to fix

      File xmodem.rb has 257 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      require 'log4r'
include Log4r

module XMODEM
      Severity: Minor
      Found in lib/xmodem.rb - About 2 hrs to fix
        Severity
        Category
        Status
        Source
        Language