Sign upLogin

ezpaarse-project/ezpaarse

View on GitHub
Star
lib/ecfilter.js

Summary

Maintainability
C
1 day
Test Coverage

Function isValid has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

exports.isValid = function (ec, job) {
  const validCodes = new Set(['200', '304']);
  const deniedCodes = new Set(['401', '403']);
  const filterRedirs = job.hasOwnProperty('filterRedirs') ? job.filterRedirs : true;
  const filterStatus = job.hasOwnProperty('filterStatus') ? job.filterStatus : true;
Severity: Minor
Found in lib/ecfilter.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function init has 51 lines of code (exceeds 25 allowed). Consider refactoring.
Open

exports.init = function (callback) {

  externalFactors.forEach(function (factors) {
    if (factors.file) {
      const filepath = path.join(__dirname, '..', factors.file);
Severity: Major
Found in lib/ecfilter.js - About 2 hrs to fix

    Function isValid has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    exports.isValid = function (ec, job) {
  const validCodes = new Set(['200', '304']);
  const deniedCodes = new Set(['401', '403']);
  const filterRedirs = job.hasOwnProperty('filterRedirs') ? job.filterRedirs : true;
  const filterStatus = job.hasOwnProperty('filterStatus') ? job.filterStatus : true;
    Severity: Minor
    Found in lib/ecfilter.js - About 1 hr to fix

      Function readFile has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          (function readFile() {
      const file = files.pop();
      if (!file) { return callback(null, Object.keys(robots).length); }

      const type = file.substr(0, file.indexOf('.'));
      Severity: Minor
      Found in lib/ecfilter.js - About 1 hr to fix

        Avoid too many return statements within this function.
        Open

          return { valid: true };
        Severity: Major
        Found in lib/ecfilter.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                return {
        valid: false,
        reason: `Ignored HTTP status code: ${ec.status}`
      };
          Severity: Major
          Found in lib/ecfilter.js - About 30 mins to fix

            Function isQualified has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

            exports.isQualified = function (ec) {
  let level = 0;
  for (const field in qualifyingFactors) {
    if (ec[field]) {
      level += qualifyingFactors[field];
            Severity: Minor
            Found in lib/ecfilter.js - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                } else if (ec.status && !validCodes.has(ec.status)) {
      // Filters http codes other than 200 or 304
      return {
        valid: false,
        reason: `Ignored HTTP status code: ${ec.status}`
            Severity: Major
            Found in lib/ecfilter.js and 1 other location - About 1 hr to fix
            lib/ecfilter.js on lines 133..139

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 58.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                if (ec.status && !filterStatus.has(ec.status)) {
      // Filters http codes which are not listed in filterStatus
      return {
        valid: false,
        reason: `Ignored HTTP status code: ${ec.status}`
            Severity: Major
            Found in lib/ecfilter.js and 1 other location - About 1 hr to fix
            lib/ecfilter.js on lines 125..131

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 58.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status