ezpaarse-project/ezpaarse

View on GitHub
routes/info.js

Summary

Maintainability
F
6 days
Test Coverage

File info.js has 420 lines of code (exceeds 250 allowed). Consider refactoring.
Open

// ##EZPAARSE

'use strict';

const fs             = require('fs-extra');
Severity: Minor
Found in routes/info.js - About 6 hrs to fix

    Function getMiddlewaresData has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
    Open

    async function getMiddlewaresData() {
      const middlewaresFolder = path.resolve(__dirname, '../middlewares');
      const result = await dbConfig.getConfig('middlewares');
      const savedMiddlewares = result && result.data;
    
    
    Severity: Minor
    Found in routes/info.js - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function getMiddlewaresData has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    async function getMiddlewaresData() {
      const middlewaresFolder = path.resolve(__dirname, '../middlewares');
      const result = await dbConfig.getConfig('middlewares');
      const savedMiddlewares = result && result.data;
    
    
    Severity: Minor
    Found in routes/info.js - About 1 hr to fix

      Function readNextDir has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          (async function readNextDir(callback) {
            const folder = folders[i++];
      
            if (!folder) { return callback(); }
            if (folder == 'js-parser-skeleton') { return readNextDir(callback); }
      Severity: Minor
      Found in routes/info.js - About 1 hr to fix

        Function getPkbPackages has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            const getPkbPackages = function (pkbDir, callback) {
              fs.readdir(pkbDir, function (err, files) {
                if (err && err.code != 'ENOENT') { return callback(err); }
        
                files = files || [];
        Severity: Minor
        Found in routes/info.js - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          app.get('/middlewares/changed', function (req, res, next) {
            git.changed({ cwd: path.join(__dirname, '../middlewares') }, function (err, files) {
              if (err) { return next(err); }
          
              const changed = {};
          Severity: Major
          Found in routes/info.js and 1 other location - About 1 day to fix
          routes/info.js on lines 60..81

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 237.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          app.get('/platforms/changed', function (req, res, next) {
            git.changed({ cwd: path.join(__dirname, '../platforms') }, function (err, files) {
              if (err) { return next(err); }
          
              const changed = {};
          Severity: Major
          Found in routes/info.js and 1 other location - About 1 day to fix
          routes/info.js on lines 347..368

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 237.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          app.get('/countries.json', function (req, res, next) {
            const countriesFile = path.resolve(__dirname, '../resources/countries.json');
          
            fs.readFile(countriesFile, function (err, data) {
              if (err) {
          Severity: Major
          Found in routes/info.js and 1 other location - About 7 hrs to fix
          routes/info.js on lines 487..507

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 185.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          app.get('/predefined-settings', function (req, res, next) {
            const settingsFile = path.join(__dirname, '/../resources/predefined-settings.json');
          
            fs.readFile(settingsFile, function (err, data) {
              if (err) {
          Severity: Major
          Found in routes/info.js and 1 other location - About 7 hrs to fix
          routes/info.js on lines 462..482

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 185.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status