Sign upLogin

fabianvf/sharepa

View on GitHub
Star

Showing 3 of 5 total issues

Function convert_nested_to_dataframe has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

def convert_nested_to_dataframe(agg, dates_as_key=True):
    '''A function that takes nested elasticsearch response with aggregation and returns a nested dataframe
        Warning: This is a recursive function, and rather non-intuitive to understand

        This function takes nested and crossed aggregations and converts them to an easy to manipulates pandas dataframe
Severity: Minor
Found in sharepa/experimental_analysis_functions.py - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function bucket_to_dataframe has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

def bucket_to_dataframe(name, buckets, append_name=None):
    '''A function that turns elasticsearch aggregation buckets into dataframes

        :param name: The name of the bucket (will be a column in the dataframe)
        :type name: str
Severity: Minor
Found in sharepa/analysis.py - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function agg_to_two_dim_dataframe has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

def agg_to_two_dim_dataframe(agg):
    '''A function that takes an elasticsearch response with aggregation and returns the names of all bucket value pairs

        :param agg: an aggregation from elasticsearch results
        :type agg: elasticsearch response.aggregation.agg_name object
Severity: Minor
Found in sharepa/analysis.py - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language