Sign upLogin

fair-search/fairsearch-elasticsearch-plugin

View on GitHub
Star
demo/server/server.js

Summary

Maintainability
C
1 day
Test Coverage

Function createMtableAndExecuteQuery has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function createMtableAndExecuteQuery(k ,p, alpha, query, req, res){
        var xhr = new XMLHttpRequest();
        var data = JSON.stringify({"from" : 0, "size" : k,"query": {"match": {"body": query}}});
        xhr.addEventListener("readystatechange", function() {
        if (this.readyState === 4) {
Severity: Minor
Found in demo/server/server.js - About 1 hr to fix

    Function createMtableAndExecuteQuery has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    function createMtableAndExecuteQuery(k ,p, alpha, query, req, res){
    Severity: Minor
    Found in demo/server/server.js - About 45 mins to fix

      Function executeFairQueryWithAdjustedParameters has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      function executeFairQueryWithAdjustedParameters(k,p,alpha,q, req, res){
      Severity: Minor
      Found in demo/server/server.js - About 45 mins to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                if(response.status === 500){
            res.status(404);
            res.send();
        }else{
            for(var i=0; i<response.hits.hits.length; i++){
        Severity: Major
        Found in demo/server/server.js and 1 other location - About 4 hrs to fix
        demo/server/server.js on lines 64..75

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 122.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                if(response.hits.hits.length === 0){
            res.status(404);
            res.send();
        }else{
        for(var i=0; i<response.hits.hits.length; i++){
        Severity: Major
        Found in demo/server/server.js and 1 other location - About 4 hrs to fix
        demo/server/server.js on lines 136..146

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 122.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status